Fuzzing integration #1004
Merged
Fuzzing integration #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what i was thinking when writing this.
This integrates fuzzing into our project by introducing two targets which exercise the descriptor parsing and analysis logic. The `descriptor_parse` is dead simple but not very effective. The `descriptors` harness tries to be smarter by almost always generating a valid Liana descriptor. Of course, this is just a first integration and both could be made more effective.
|
ACK 3017b88 - it's not interfering with anything in the repo, been running these for half a day with no crash. |
darosior
commented
Mar 13, 2024
| /// Generate the data for this path. We reuse the same xpub across the board as it doesn't | ||
| /// matter. However we change the fingerprint, as it matters for the spend info analysis. | ||
| pub fn info(&self, path_index: u8) -> Option<PathInfo> { | ||
| if self.thresh > self.count || self.count > 100 { |
There was a problem hiding this comment.
Missing check for count == 0...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces fuzzing into our project with two fuzz targets exercising our descriptor parsing logic. See the commit messages for details. This found a crash (first commit).
This was motivated by testing the work on Taproot (#985).