Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ar): Update nav.ts #7954

Merged
merged 204 commits into from
May 15, 2024
Merged

Conversation

wpplumber
Copy link
Contributor

Description (required)

I translated nav.ts.

Related issues & labels (optional)

  • Suggested label: i18n

First-time contributor to Astro Docs?

@tarik

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 15, 2024 4:40pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 19, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 19, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ar nav.ts Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@yanthomasdev
Copy link
Member

Thanks @wpplumber, I'll just ask you to update the format the file is on.

As shown in the comment above this file:

/**
 * This configures the navigation sidebar.
 * All other languages follow this ordering/structure and will fall back to
 * English for any entries they haven’t translated.
 *
 * - All entries MUST include `text` and `key`
 * - Heading entries MUST include `header: true` and `type`
 * - Link entries MUST include `slug` (which excludes the language code)
 *
 * For translators:
 *
 * Copy the English `key` value unchanged and translate only the `text` into your language:
 *
 * `src/i18n/en/nav.ts`: `{ text: 'Getting Started', slug: 'getting-started', key: 'getting-started' },`
 * `src/i18n/ja/nav.ts`: `'getting-started': 'はじめに',`
 */

It should go back to the format it had before but with the keys updated, like so:

export default NavDictionary({
	// Start Here
	startHere: 'ابدأ هنا',
	'getting-started': 'دليل البداية',
	install: 'التثبيت',
	'editor-setup': 'إعداد المحرر',
	// (more keys...)
});

@wpplumber
Copy link
Contributor Author

Welcome @yanthomasdev,

It should go back to the format it had before

I think I'm using the latest format used in the English version!

@yanthomasdev
Copy link
Member

I think I'm using the latest format used in the English version!

Hey @wpplumber, sorry if I wasn't clear.

So, the format used in the English version is different because it has some additional metadata necessary to build the docs dashboard, those extra properties are not necessary in translations, and to avoid issues we ask for them to not be included in this case.

With the export default NavDictionary({}) format, you can only add the key of sidebar item and the translation as its value, and that makes it easier for future changes by you or other contributors without having to worry about the extra properties.

Again, here's the comment example from the file:

 * For translators:
 *
 * Copy the English `key` value unchanged and translate only the `text` into your language:
 *
 * `src/i18n/en/nav.ts`: `{ text: 'Getting Started', slug: 'getting-started', key: 'getting-started' },`
 * `src/i18n/ja/nav.ts`: `'getting-started': 'はじめに',`
 */

Let me know if you have any issues making this change!

xieyumc and others added 22 commits May 9, 2024 10:11
This part has not been translated into Chinese.

Co-authored-by: liruifengv <[email protected]>
Small typo in the second bullet of the Table References section of the Astro-DB info @ line 112

Missing a 'to' between property and establish
* i18n(es): update `5-astro-api`

* fix: identation issue

---------

Co-authored-by: Yan <[email protected]>
* i18n(de): add svelte integration

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Because789 <[email protected]>

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Because789 <[email protected]>

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/guides/integrations-guide/svelte.mdx

Co-authored-by: Max <[email protected]>

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Because789 <[email protected]>
Co-authored-by: Yan <[email protected]>
liruifengv and others added 23 commits May 15, 2024 10:43
* i18n(zh-cn): update markdown-content.mdx

* Update src/content/docs/zh-cn/guides/markdown-content.mdx
…ithastro#8250)

* i18n(fr): Update `guides/cms/apostrophecms.mdx` from withastro#7568

Signed-off-by: Thomas Bonnet <[email protected]>

* Fix absolute link

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan <[email protected]>
* i18n(fr): Update `mdx.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `mdx.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `mdx.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `preact.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `solid-js.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `vercel.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `vue.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `testing.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `error-reference.mdx` file from withastro#8224

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/solid-js.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/preact.mdx

Co-authored-by: pioupia <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: pioupia <[email protected]>
Co-authored-by: Yan <[email protected]>
* i18n(es): add `route-not-found`

* add: meaningless commit to rerun workflows on GitHub

---------

Co-authored-by: Yan <[email protected]>
…ro#8260)

* i18n(fr): Update `ecommerce.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `rss.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `add-yaml-support.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `build-custom-img-component.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `build-forms-api.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `build-forms.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `call-endpoints.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `captcha.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `docker.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `dynamically-importing-images.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `external-links.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `i18n.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `modified-time.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `sharing-state.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `tailwind-rendered-markdown.mdx` file from withastro#8167 (STEPS)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix Steps indents in external-links.mdx

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix indents ?

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix indents ?

Signed-off-by: Thomas Bonnet <[email protected]>

* Discard changes to src/content/docs/en/recipes/external-links.mdx

* Update `docker.mdx` to withastro#8226

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan <[email protected]>
A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.

Co-authored-by: Yan <[email protected]>
* i18n(pl): update nav.ts

* fix: add missing commas

* fix: make changes requested by reviewer

---------

Co-authored-by: Yan <[email protected]>
* i18n(ko-KR): add `umbraco.mdx`

* Remove absolute links

---------

Co-authored-by: Yan <[email protected]>
* i18n(zh-cn): Update `cli-reference.mdx`

* Update src/content/docs/zh-cn/reference/cli-reference.mdx

Co-authored-by: liruifengv <[email protected]>

---------

Co-authored-by: liruifengv <[email protected]>
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wpplumber

@yanthomasdev yanthomasdev merged commit 1daa305 into withastro:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.