-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple Yubikeys and Maintenance #15
base: master
Are you sure you want to change the base?
Conversation
ddcba54
to
33e950a
Compare
Hi @wisespace-io , Can you review merge and publish? |
@ashuio looking forward to this feature! Was bumping the dependencies a requirement for implementing this feature? I would suggest opening a separate PR for the dependency changes that are not related to the new feature. Also, it looks like the code was auto-formatted. Ideally that would be isolated in the first commit, to make it easier to review the PR without reviewing the reformatting. |
@louib, Thanks for taking a look at this The dependency updates are not strictly required for the new features but since we're bumping the version number, I included that in the PR. Unfortunately, I won't be able to open another PR as of now dur to time constraints on other Projects. |
hey @louib since we haven't heard from @wisespace-io for so long I was forced to fork this project and publish a new crate with my changes in order to use it in my own app. |
Hey @louib can you send the invite again to |
By the way, I see the you have a fork now. However, if you want to maintain this project, I can give you access. |
Hi, @wisespace-io
This PR adds support for multiple YubiKeys and closes #14
It also bumped dependencies.