Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple Yubikeys and Maintenance #15

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ashuio
Copy link
Contributor

@ashuio ashuio commented Dec 23, 2023

Hi, @wisespace-io
This PR adds support for multiple YubiKeys and closes #14

It also bumped dependencies. 

@ashuio ashuio force-pushed the master branch 2 times, most recently from ddcba54 to 33e950a Compare December 24, 2023 12:45
@ashuio
Copy link
Contributor Author

ashuio commented Dec 25, 2023

Hi @wisespace-io ,

Can you review merge and publish?

@louib
Copy link
Contributor

louib commented Dec 30, 2023

@ashuio looking forward to this feature!

Was bumping the dependencies a requirement for implementing this feature? I would suggest opening a separate PR for the dependency changes that are not related to the new feature.

Also, it looks like the code was auto-formatted. Ideally that would be isolated in the first commit, to make it easier to review the PR without reviewing the reformatting.

@ashuio
Copy link
Contributor Author

ashuio commented Jan 4, 2024

@louib, Thanks for taking a look at this

The dependency updates are not strictly required for the new features but since we're bumping the version number, I included that in the PR.

Unfortunately, I won't be able to open another PR as of now dur to time constraints on other Projects.

@ashuio
Copy link
Contributor Author

ashuio commented Jan 15, 2024

hey @louib since we haven't heard from @wisespace-io for so long I was forced to fork this project and publish a new crate with my changes in order to use it in my own app.

https://github.com/ashuio/yubikey-hmac-otp

https://crates.io/crates/yubikey-hmac-otp

@ashuio
Copy link
Contributor Author

ashuio commented Jan 16, 2024

Hey @louib can you send the invite again to

[email protected]

@wisespace-io
Copy link
Owner

@louib and @ashuio , sorry for the silence. I merged the previous PR, we have merging conflicts here now. Could you fix them so I can merge this one as well?

@wisespace-io
Copy link
Owner

By the way, I see the you have a fork now. However, if you want to maintain this project, I can give you access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple Yubikeys
4 participants