Speed improvement by replacing View composer (#239)

wire-elements · Jul 5, 2022 · 8daf260 · 8daf260
1 parent 96c8937
commit 8daf260
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/src/LivewireModalServiceProvider.php b/src/LivewireModalServiceProvider.php
@@ -20,15 +20,5 @@ public function configurePackage(Package $package): void
     public function bootingPackage(): void
     {
         Livewire::component('livewire-ui-modal', Modal::class);
-
-        View::composer('livewire-ui-modal::modal', function ($view) {
-            if (config('livewire-ui-modal.include_js', true)) {
-                $view->jsPath = __DIR__.'/../public/modal.js';
-            }
-
-            if (config('livewire-ui-modal.include_css', false)) {
-                $view->cssPath = __DIR__ . '/../public/modal.css';
-            }
-        });
     }
 }
diff --git a/src/Modal.php b/src/Modal.php
@@ -64,6 +64,17 @@ public function getListeners(): array
 
     public function render(): View
     {
-        return view('livewire-ui-modal::modal');
+        if (config('livewire-ui-modal.include_js', true)) {
+            $jsPath = __DIR__.'/../public/modal.js';
+        }
+
+        if (config('livewire-ui-modal.include_css', false)) {
+            $cssPath = __DIR__ . '/../public/modal.css';
+        }
+
+        return view('livewire-ui-modal::modal', [
+            'jsPath' => $jsPath ?? null,
+            'cssPath' => $cssPath ?? null,
+        ]);
     }
 }