Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Editor - Add link and image support #4711

Merged
merged 18 commits into from
Jan 11, 2024
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T348071

Notes

Implements syntax highlighting and actions for link and images.

Test Steps

  1. Visit article.
  2. Confirm links and labelled links are syntax highlighted.
  3. Confirm image links are syntax highlighted (will look something like [[File:...]])
  4. Tap inside of link. Confirm link buttons show selected state and image button shows disabled state.
  5. Tap selected link button. Confirm link edit wizard appears. Change link and confirm changes reflect in textView.
  6. Tap outside of a link. Confirm image button shows as enabled.
  7. Tap image button. Go through wizard to insert an image. Confirm image wikitext inserts into textView.

@tonisevener tonisevener requested a review from mazevedofs January 8, 2024 15:08
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mazevedofs mazevedofs merged commit 261a1fd into main Jan 11, 2024
3 checks passed
@mazevedofs mazevedofs deleted the native-editor-links-images branch January 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants