fix: restore kernel context on reactive event handler #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a reactive variable was set from a different (or no) kernel context, the event handler would not restore the kernel context that was active when the event handler was registered. Fixes #961
maartenbreddels
temporarily deployed
to
fix_restore_kernel_context_on_reactive_event_handler - solara-stable PR #962
Render
Destroyed
…xt on subscribe In use_reactive, the subscribe did not pass a context, so it was None. We now always store the context for listeners, and we also rename the scope to context.
maartenbreddels
force-pushed
the
fix_restore_kernel_context_on_reactive_event_handler
branch
from
4b0df66 to
a6a9607
Compare
maartenbreddels
temporarily deployed
to
fix_restore_kernel_context_on_reactive_event_handler - solara-stable PR #962
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a reactive variable was set from a different (or no) kernel context,
the event handler would not restore the kernel context that was
active when the event handler was registered.
Fixes #961