fix: threaded task is_current() will return False after cancelling. #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_cancel_task_is_current
branch
from
4efdc8a to
f96f8b6
Compare
maartenbreddels
force-pushed
the
master
branch
from
a5103a7 to
3d92b35
Compare
maartenbreddels
force-pushed
the
fix_cancel_task_is_current
branch
from
f96f8b6 to
9e7ec18
Compare
maartenbreddels
force-pushed
the
master
branch
from
3d92b35 to
cded5b2
Compare
maartenbreddels
force-pushed
the
fix_cancel_task_is_current
branch
from
9e7ec18 to
4bb5f2a
Compare
maartenbreddels
force-pushed
the
master
branch
from
cded5b2 to
32af76f
Compare
This was the case for async tasks, not yet for threaded tasks.
maartenbreddels
force-pushed
the
fix_cancel_task_is_current
branch
from
4bb5f2a to
75c333b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the case for async tasks, not yet for threaded tasks.