Use Romaji Lyrics when avaible with Genius toggle. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash before/if merging, I had a lot of experimenting lol... |
yodaluca23
added a commit
to yodaluca23/EeveeSpotify
that referenced
this pull request
Jul 7, 2024
* Update GeniusLyricsRepository.swift * Update GeniusLyricsRepository.swift * Update EeveeSettingsViewController+LyricsSections.swift * Update UserDefaults+Extension.swift * Update GeniusLyricsRepository.swift * Update GeniusLyricsRepository.swift * Update GeniusLyricsRepository.swift * Update UserDefaults+Extension.swift * Update EeveeSettingsViewController+LyricsSections.swift * Update EeveeSettingsViewController+LyricsSections.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225
Adds a switch in settings to enable
UserDefaults.romanizedLyrics.Reworked Genius quarrying logic, to allow for multiple search attempts. This will also allow for multiple quary formats if needed/wanted.
if
UserDefaults.romanizedLyricsis enabled first search for "(strippedTitle) (query.primaryArtist) (Romanized)" when using Genius, if that throws an error, and fallback to "(strippedTitle) (query.primaryArtist)".Currently nothing is preventing the Romanized quary from being used if Genius is triggered as a fallback from another source, this could be easily added, but I was unsure if it is wanted...