Editorial: add a table for the translate attribute #9951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
editorial-add-a-table-for-the-translate-attribute
branch
2 times, most recently
from
353dc14 to
8032540
Compare
keithamus
force-pushed
the
editorial-add-a-table-for-the-translate-attribute
branch
from
8032540 to
29eaf96
Compare
mtrootyy
reviewed
Nov 24, 2023
domenic
requested changes
Nov 27, 2023
domenic
reviewed
Nov 28, 2023
domenic
reviewed
Nov 29, 2023
domenic
approved these changes
Nov 29, 2023
keithamus
deleted the
editorial-add-a-table-for-the-translate-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #9832 the
translateenumerated attribute lacked a table. This PR adds a table for the attribute, enumerating the keywords and states, and describing what each state does.The prose below the table goes into some more detail about the states, which feels a little redundant, but there is extra information in there so I didn't want to get too liberal with editing it. I'm happy to take direction here if we feel it needs reducing more.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Nov 29, 2023, 9:11 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.