Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Update Explainer Introduction to include "readwrite-unsafe" example. #152

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nathanmemmott
Copy link
Contributor

Updates explainer introduction so that "readwrite-unsafe" is included in the example.

@a-sully
Copy link
Collaborator

a-sully commented Nov 21, 2023

Looks good, though I'll copy this note from #67 (review):

please read https://github.com/whatwg/meta/blob/main/MAINTAINERS.md and in particular https://github.com/whatwg/meta/blob/main/COMMITTING.md for commit message guidelines. We try to stick to certain rules which in turn influences what ends up on Twitter and such and also ensures our commit logs are readable/scannable across standards.

So in this case, please prefix the title with Meta: (since this isn't updating the spec itself) and make sure to squash and merge according to those guidelines. Lemme know if you have any questions :)

@nathanmemmott nathanmemmott changed the title Update Explainer Introduction to include "readwrite-unsafe" example. Meta: Update Explainer Introduction to include "readwrite-unsafe" example. Nov 21, 2023
Updates explainer introduction so that "readwrite-unsafe" is included in
the example.
@nathanmemmott nathanmemmott force-pushed the update_explainer_introduction branch from a797410 to b21ed06 Compare November 21, 2023 23:19
@a-sully a-sully merged commit bd6ef5a into whatwg:main Nov 22, 2023
1 check passed
@nathanmemmott nathanmemmott deleted the update_explainer_introduction branch December 8, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants