Skip to content

Commit

Permalink
Merge branch 'whatwg:main' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanmemmott authored Jun 13, 2024
2 parents 201dd2f + b38f13b commit 72112d3
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ max_line_length = 100
[Makefile]
indent_style = tab

[*.md]
max_line_length = off

[*.bs]
indent_size = 1

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
name: Build

on:
pull_request:
branches:
- main
push:
branches:
- main
workflow_dispatch:

jobs:
build:
name: Build
Expand All @@ -17,6 +20,7 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: "3.11"
- run: pip install bikeshed && bikeshed update
# Note: `make deploy` will do a deploy dry run on PRs.
- run: make deploy
env:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ remote: index.bs
);

local: index.bs
bikeshed spec index.bs index.html --md-Text-Macro="COMMIT-SHA LOCAL COPY"
bikeshed spec index.bs index.html --md-Text-Macro="COMMIT-SHA LOCAL-COPY"

deploy: index.bs
curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh
Expand Down
5 changes: 5 additions & 0 deletions proposals/MultipleReadersWriters.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ childAccessHandle.close();
await parentHandle.remove(); // successful
```

### Interactions with BFCache
A page may still hold a file system lock when it enters the BFCache. A fully active page could then be made aware of a BFCached page if there is contention between locks they hold.

To keep BFCache enabled when a site uses the File System Access API, a BFCached page must be evicted on locking contention with a fully active page (whether or not it is of the same origin). Otherwise, a file system lock held by a page will not affect the page's eligibility for BFCache. This allows the site to have the performance gains of BFCache up until it would be made aware of the BFCache.

## Alternatives Considered

### Not Locking File Entry
Expand Down

0 comments on commit 72112d3

Please sign in to comment.