Macros: support for character and string literals #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaf
force-pushed
the
macro-strings
branch
2 times, most recently
from
0a5e856 to
d225e6d
Compare
|
Add examples (tests) |
Yes, that's the next step. This is a draft. |
This commit adds support for C character literals and string literals
in macros.
Some remarks:
- The implementation assumes that the source file is encoded in UTF-8.
I believe that's the only encoding that the Clang library supports
anyway.
- The implementation doesn't support wide character types,
such as 'uint16_t'.
- C character literals are of type 'int', not 'char'. We distinguish
two types of such literals, as per the C standard:
* code unit: a specific 'int' value, whose interpretation as a
linguistic or symbolic character depends on the choice of a
text encoding,
* Unicode code point: a unique numeric identifier for a specific
character, whose value (e.g. in a 'char *' array) depends on the
text encoding chosen.
- We translate character literals to 'CInt', and use unboxed 'Addr#'
literals to translate string literals to 'CStringLen' (allowing for
the possibility of inner null bytes).
phadej
reviewed
Feb 7, 2025
| @@ -142,6 +145,7 @@ data SExpr ctx = | |||
| | EIntegral Integer (Maybe HsPrimType) | |||
| | EFloat Float HsPrimType -- ^ Type annotation to distinguish Float/CFLoat | |||
| | EDouble Double HsPrimType | |||
| | EString [Word8] | |||
There was a problem hiding this comment.
Can't we use ByteArray, or some better representation. [Word8] doesn't feel good.
phadej
reviewed
Feb 7, 2025
| goChar (C.CharLiteral { charLiteralValue = c }) = | ||
| ( `Hs.VarDeclIntegral` HsPrimCInt ) <$> | ||
| case c of | ||
| C.CodeUnit u |
There was a problem hiding this comment.
extract into separate functions. Preferably don't invent UTF8 parsing validation, there are plenty in the libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for C character literals and string literals in macros.
Some remarks:
char16_t.int, notchar. We distinguish two types of such literals, as per the C standard:intvalue, whose interpretation as a linguistic or symbolic character depends on the choice of a text encoding,char *array) depends on the text encoding chosen.CInt, and use unboxedAddr#literals to translate string literals toCStringLen(allowing for the possibility of inner null bytes).