-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli interface for script adding/editing functions #6
Add cli interface for script adding/editing functions #6
Conversation
f2bbbf4
to
ecb9f22
Compare
@henrykironde @zhangcandrew is it fine now? |
Hey @harshitbansal05, I haven't tested it yet. Can you include screenshots of example runs of this program on your cli and add descriptions? |
@zhangcandrew @henrykironde the screenshots:
|
Thanks Harshit, I think there are a couple minor things we should fix up before merging in, but overall, it looks in a state that will be good to merge :) |
Correct me if am wrong. Looks like the required changes are related to making the edit functionality work as expected. We could add that here or create an Issue and we get this in. |
@henrykironde, we were just talking about how if you use edit_json and change the name of the scripts, a second version of the script is created with the new name while the script with the old names still stays. I think we talked about this previously before, but I think the correct functionality should be to replace the old scripts with the new name script, leaving no trace of the old script. |
@harshitbansal05, let's try to keep track of the reviews and comments that have been requested by the reviewers. |
@henrykironde @zhangcandrew just created an issue #10 for the |
a19f4ad
to
8149aae
Compare
@zhangcandrew I added more search paths for the |
8149aae
to
a1786b8
Compare
Looks good to merge in! Thanks for fixing issues. One last thing, can you change the |
@zhangcandrew sure. However, it did work for me. |
@zhangcandrew a polite reminder. |
Redesign the hard coded parts |
@zhangcandrew @henrykironde done. |
@zhangcandrew @henrykironde can this go in now? |
LGTM, mergin in |
No description provided.