Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #200

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Update README.md #200

merged 1 commit into from
Jul 1, 2024

Conversation

alenbaby13
Copy link
Contributor

@alenbaby13 alenbaby13 commented Jun 28, 2024

Ticket Link


Related Links


Description


Steps to Reproduce / Test



Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

GIF's


Live Link


Summary by CodeRabbit

  • Documentation
    • Updated hyperlinks in the README.md file to include proper query parameters for source tracking.

Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

The recent update to the "react-template" project's README.md file focuses on improving the accuracy of the source tracking for hyperlinks. This change involved updating URL query parameters by replacing gthb with github. No functional code or exported entities within the repository were altered.

Changes

Files Summary of Changes
README.md Updated hyperlink query parameters from gthb to github for better source tracking.

Poem

In the realm of code where links do weave,
New paths now trod, with truth they cleave.
From gthb to github, a small tweak's might,
Ensures our tracking stays precise and right.
A tiny tale of clarity, beneath the README's light.


📝✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (3)
README.md (3)

Line range hint 221-221: Grammar Adjustment: Use Hyphens in "End-to-End"

For consistency and correct grammar, the phrase "End to End" should be hyphenated when used as an adjective before a noun.

- End to End testing using playwright
+ End-to-End testing using playwright

Also applies to: 223-223, 230-230

Tools
Markdownlint

1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


5-5: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


Line range hint 242-242: Add Missing Commas for Clarity

Adding commas after "take a look at" improves the readability of the instructions.

- For the documentation take a look at: [playwright](https://playwright.dev/docs/intro)
+ For the documentation, take a look at: [playwright](https://playwright.dev/docs/intro)

- For the documentation take a look at: [react-floki](https://github.com/wednesday-solutions/react-floki)
+ For the documentation, take a look at: [react-floki](https://github.com/wednesday-solutions/react-floki)

Also applies to: 250-250

Tools
Markdownlint

1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


5-5: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


Line range hint 155-155: Specify Language for Code Blocks

For better readability and syntax highlighting, specify the language for code blocks.

- ```
+ ```bash

Also applies to: 161-161, 232-232, 238-238, 247-247

Tools
Markdownlint

1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


5-5: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7898804 and 3d10ae8.

Files selected for processing (1)
  • README.md (2 hunks)
Additional context used
LanguageTool
README.md

[grammar] ~221-~221: Did you mean the adjective “End-to-End” (spelled with hyphens)?
Context: ...p/components/T/tests/index.test.js) ## End to End testing using playwright - End to End ...

(END_TO_END_HYPHEN)


[grammar] ~223-~223: Did you mean the adjective “End-to-End” (spelled with hyphens)?
Context: ... End to End testing using playwright - End to End testing is done using [playwright](http...

(END_TO_END_HYPHEN)


[grammar] ~230-~230: Did you mean the adjective “End-to-End” (spelled with hyphens)?
Context: ...](tests/example.spec.js) - Run all End to End tests using ``` yarn test:e2e ``...

(END_TO_END_HYPHEN)


[uncategorized] ~242-~242: Possible missing comma found.
Context: ... test:e2e ``` For the documentation take a look at: [playwright](https://pl...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~250-~250: Possible missing comma found.
Context: ...g yarn generate For the documentation take a look at: [react-floki](https://g...

(AI_HYDRA_LEO_MISSING_COMMA)

Markdownlint
README.md

247-247: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


249-249: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


155-155: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


161-161: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


232-232: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


238-238: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


247-247: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


5-5: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


26-26: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


29-29: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


42-42: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


43-43: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


46-46: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


47-47: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Additional comments not posted (3)
README.md (3)

4-4: Update URL Query Parameters

The change in the URL query parameters from gthb to github is appropriate for better source tracking. This is a straightforward update and seems correctly implemented here.


25-25: Update Contact and GitHub Links

The updated URLs in the anchor tags for contacting and following on GitHub are modified appropriately. This change aligns with the PR's objective to improve source tracking.


Line range hint 247-247: Add Blank Lines Around Fenced Code Blocks

For proper markdown formatting, ensure that fenced code blocks are surrounded by blank lines.

+ 

yarn generate

+ 

Also applies to: 249-249

Tools
Markdownlint

1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


5-5: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

@@ -1,7 +1,7 @@
<img align="left" src="https://github.com/wednesday-solutions/react-template/blob/master/react_template_github.svg" width="480" height="540" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Alt Text to Images

For accessibility and SEO, it's important to include alternative text for images.

- <img src="https://github.com/wednesday-solutions/react-template/blob/master/react_template_github.svg" width="480" height="540" />
+ <img src="https://github.com/wednesday-solutions/react-template/blob/master/react_template_github.svg" alt="React Template Logo" width="480" height="540" />

- <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f5879492fafecdb3e5b0e75_wednesday_logo.svg">
+ <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f5879492fafecdb3e5b0e75_wednesday_logo.svg" alt="Wednesday Logo">

- <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f6ae88b9005f9ed382fb2a5_button_get_in_touch.svg" width="121" height="34">
+ <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f6ae88b9005f9ed382fb2a5_button_get_in_touch.svg" alt="Get in Touch Button" width="121" height="34">

- <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f6ae88bb1958c3253756c39_button_follow_on_github.svg" width="168" height="34">
+ <img src="https://uploads-ssl.webflow.com/5ee36ce1473112550f1e1739/5f6ae88bb1958c3253756c39_button_follow_on_github.svg" alt="Follow on GitHub Button" width="168" height="34">

Also applies to: 5-5, 26-26, 29-29, 42-43, 46-47

Tools
Markdownlint

1-1: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

@alichherawalla alichherawalla merged commit 0598030 into master Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants