Skip to content

Commit

Permalink
Merge pull request #194 from wednesday-solutions/feat/default-templat…
Browse files Browse the repository at this point in the history
…e-placeholder

feat: add default template placeholder
  • Loading branch information
alichherawalla authored Mar 5, 2024
2 parents 3153716 + 7c2068f commit a01fdad
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,8 @@ jobs:
- name: LHCI Benchmark
run: yarn lhci

- name: SonarCloud Scan
uses: sonarsource/sonarcloud-github-action@master
with:
args: >
-Dsonar.organization=${{ secrets.SONAR_ORG}}
-Dsonar.projectKey=${{ secrets.SONAR_PROJECT_KEY}}
- name: SonarQube Scan
uses: sonarsource/sonarqube-scan-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ exports[`<ProtectedRoute /> should render and match the snapshot 1`] = `
<input
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedEnd css-nxo287-MuiInputBase-input-MuiOutlinedInput-input"
data-testid="search-bar"
placeholder="wednesday-solutions/react-template"
type="text"
value=""
/>
Expand Down
1 change: 1 addition & 0 deletions app/containers/HomeContainer/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export function HomeContainer({
onChange={(event) => debouncedHandleOnChange(event.target.value)}
fullWidth
defaultValue={repoName}
placeholder={translate('default_template')}
endAdornment={
<InputAdornment position="end">
<IconButton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ exports[`<HomeContainer /> tests should render and match the snapshot 1`] = `
<input
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedEnd css-nxo287-MuiInputBase-input-MuiOutlinedInput-input"
data-testid="search-bar"
placeholder="wednesday-solutions/react-template"
type="text"
value=""
/>
Expand Down
3 changes: 2 additions & 1 deletion app/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
"search_query": "Search query: {repoName}",
"something_went_wrong": "Sorry. Something went wrong! Please try again in sometime.",
"stories": "Go to Storybook",
"wednesday_solutions": "Wednesday Solutions"
"wednesday_solutions": "Wednesday Solutions",
"default_template": "wednesday-solutions/react-template"
}
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
sonar.organization=wednesday-solutions
sonar.projectKey=wednesday-solutions_react-template
sonar.projectKey=wednesday-solutions_react-template_AY4NDr6dB2n8RRmGoUim

sonar.language=js
sonar.sources=.
Expand Down

0 comments on commit a01fdad

Please sign in to comment.