Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KYAN-1295 (WSIO-1295) fix navbar hover issue #510

Merged
merged 2 commits into from
Oct 10, 2024
Merged

KYAN-1295 (WSIO-1295) fix navbar hover issue #510

merged 2 commits into from
Oct 10, 2024

Conversation

martyna-ds
Copy link
Contributor

Description

Motivation and Context

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue) labeled with bug
  • New feature (non-breaking change which adds functionality) labeled with enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code standards of this project.
  • My change requires updating the documentation. I have updated the documentation accordingly.

@martyna-ds martyna-ds self-assigned this Oct 10, 2024
@martyna-ds martyna-ds changed the title WSIO-1295 fix navbar hover issue KYAN-1295, WSIO-1295 fix navbar hover issue Oct 10, 2024
@martyna-ds martyna-ds changed the title KYAN-1295, WSIO-1295 fix navbar hover issue KYAN, WSIO-1295 fix navbar hover issue Oct 10, 2024
@martyna-ds martyna-ds changed the title KYAN, WSIO-1295 fix navbar hover issue KYAN-WSIO-1295 fix navbar hover issue Oct 10, 2024
@martyna-ds martyna-ds changed the title KYAN-WSIO-1295 fix navbar hover issue KYAN WSIO-1295 fix navbar hover issue Oct 10, 2024
@martyna-ds martyna-ds changed the title KYAN WSIO-1295 fix navbar hover issue KYAN-1296 (WSIO-1295) fix navbar hover issue Oct 10, 2024
@martyna-ds martyna-ds changed the title KYAN-1296 (WSIO-1295) fix navbar hover issue KYAN-1295 (WSIO-1295) fix navbar hover issue Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Visual tests status

Some visual changes require review.

Please download BackstopJS report and check if there is no visual regression.

Please note that the report only stay for 1 day!

Name Link
Commit 29243ae
Logs https://github.com/websight-io/kyanite/actions/runs/11270112387
Report visual-tests-report_2024-10-10T083708.zip

botondmezei
botondmezei approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@botondmezei botondmezei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@martyna-ds
Copy link
Contributor Author

Corrected after verifying visual tests

@github-actions GitHub Actions
Copy link
Contributor

✅ Visual tests status

No visual changes detected.

Name Link
Commit f87e199
Logs https://github.com/websight-io/kyanite/actions/runs/11271519809

@martyna-ds martyna-ds merged commit 0824633 into main Oct 10, 2024
3 checks passed
@martyna-ds martyna-ds deleted the WSIO-1295-fix-ux-issues-with-megamenu-on-some-browsers-naviagtion-via-megamenu-is-impossible branch October 10, 2024 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@botondmezei botondmezei botondmezei approved these changes

Assignees

@martyna-ds martyna-ds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martyna-ds @botondmezei