Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #101. #102

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for Issue #101. #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca41aaa
allow publish assets
latik Jan 11, 2018
58717d7
Merge pull request #86 from latik/develop
webpatser May 16, 2018
3791642
Merge branch 'master' into develop
webpatser May 16, 2018
2b3f9f0
Fix for issue #101. Added missing currency decimals and symbols.
AlexHoogendoorn Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ Now add the alias.
]


Publish the public assets:

```
php artisan vendor:publish --provider='Webpatser\\Countries\\CountriesServiceProvider' --tag=assets
```

## Model

You can start by publishing the configuration. This is an optional step, it contains the table name and does not need to be altered. If the default name `countries` suits you, leave it. Otherwise run the following command
Expand Down
4 changes: 4 additions & 0 deletions src/Webpatser/Countries/CountriesServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ public function boot()
// The publication files to publish
$this->publishes([__DIR__ . '/../../config/config.php' => config_path('countries.php')]);

$this->publishes([
__DIR__ . '/../../flags' => public_path('vendor/countries/flags'),
], 'assets');

// Append the country settings
$this->mergeConfigFrom(
__DIR__ . '/../../config/config.php', 'countries'
Expand Down
45 changes: 33 additions & 12 deletions src/Webpatser/Countries/Models/countries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 +1400,9 @@
"region-code":"150",
"sub-region-code":"154",
"eea":false,
"calling_code":"358"
"calling_code":"358",
"currency_symbol":"\u20ac",
"currency_decimals":"2"
},
"250":{
"capital":"Paris",
Expand Down Expand Up @@ -2874,7 +2876,9 @@
"region-code":"019",
"sub-region-code":"029",
"eea":false,
"calling_code":"599"
"calling_code":"599",
"currency_symbol":"\u0192",
"currency_decimals":"2"
},
"533":{
"capital":"Oranjestad",
Expand Down Expand Up @@ -2909,7 +2913,9 @@
"region-code":"019",
"sub-region-code":"029",
"eea":false,
"calling_code":"721"
"calling_code":"721",
"currency_symbol":"\u0192",
"currency_decimals":"2"
},
"535":{
"citizenship":"of Bonaire, Sint Eustatius and Saba",
Expand All @@ -2923,7 +2929,9 @@
"region-code":"019",
"sub-region-code":"029",
"eea":false,
"calling_code":"599"
"calling_code":"599",
"currency_symbol":"$",
"currency_decimals":"2"
},
"540":{
"capital":"Noum\u00e9a",
Expand Down Expand Up @@ -3528,7 +3536,9 @@
"region-code":"019",
"sub-region-code":"029",
"eea":false,
"calling_code":"590"
"calling_code":"590",
"currency_symbol":"\u20ac",
"currency_decimals":"2"
},
"654":{
"capital":"Jamestown",
Expand Down Expand Up @@ -3620,7 +3630,9 @@
"region-code":"019",
"sub-region-code":"029",
"eea":false,
"calling_code":"590"
"calling_code":"590",
"currency_symbol":"\u20ac",
"currency_decimals":"2"
},
"666":{
"capital":"Saint-Pierre",
Expand Down Expand Up @@ -3750,7 +3762,8 @@
"region-code":"150",
"sub-region-code":"039",
"eea":false,
"calling_code":"381"
"calling_code":"381",
"currency_decimals":"2"
},
"690":{
"capital":"Victoria",
Expand Down Expand Up @@ -3956,7 +3969,8 @@
"region-code":"002",
"sub-region-code":"015",
"eea":false,
"calling_code":"211"
"calling_code":"211",
"currency_decimals":"2"
},
"729":{
"capital":"Khartoum",
Expand All @@ -3972,7 +3986,8 @@
"region-code":"002",
"sub-region-code":"015",
"eea":false,
"calling_code":"249"
"calling_code":"249",
"currency_decimals":"2"
},
"732":{
"capital":"Al aaiun",
Expand Down Expand Up @@ -4444,7 +4459,9 @@
"region-code":"150",
"sub-region-code":"154",
"eea":false,
"calling_code":"44"
"calling_code":"44",
"currency_symbol":"\u00a3",
"currency_decimals":"2"
},
"832":{
"capital":"St Helier",
Expand All @@ -4460,7 +4477,9 @@
"region-code":"150",
"sub-region-code":"154",
"eea":false,
"calling_code":"44"
"calling_code":"44",
"currency_symbol":"\u00a3",
"currency_decimals":"2"
},
"833":{
"capital":"Douglas",
Expand All @@ -4476,7 +4495,9 @@
"region-code":"150",
"sub-region-code":"154",
"eea":false,
"calling_code":"44"
"calling_code":"44",
"currency_symbol":"\u00a3",
"currency_decimals":"2"
},
"834":{
"capital":"Dodoma (TZ1)",
Expand Down