Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Types: Improve testing of samples in violation reports. #50238

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

fred-wang
Copy link
Contributor

@fred-wang
Copy link
Contributor Author

cc @lukewarlow

@fred-wang fred-wang requested a review from lukewarlow January 23, 2025 13:20
@fred-wang
Copy link
Contributor Author

I'm not really sure about the SVG and script related things...

@fred-wang fred-wang marked this pull request as ready for review January 23, 2025 13:21
@lukewarlow
Copy link
Member

lukewarlow commented Jan 23, 2025

LGTM we can revise the SVG ones as appropriate. Shame we can't run them in Chrome to see what's up. Seems Chrome still needs to remove the TT protection for Object.

Haven't ran these tests locally so I'm assuming you did on your end, but it all looks correct

@fred-wang fred-wang merged commit ef244b7 into master Jan 23, 2025
13 of 16 checks passed
@fred-wang fred-wang deleted the tt-violation-samples branch January 23, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants