Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(assets-retry): reduce nullish coalescing operator #4325

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 5, 2025

Summary

The nullish coalescing operator is very useful in modern JS code, but it generates some extra code when it is transpiled to ES5.

This PR uses || to replace ?? because they are equivalent in the assets retry runtime code.

  • initialChunkRetry.min.js: 3,980 bytes -> 3,946 bytes
  • asyncChunkRetry.min.js: 3,778 bytes -> 3,575 byte

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ce08250
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/677a54001e075000087f4ecc
😎 Deploy Preview https://deploy-preview-4325--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit aed200f into main Jan 5, 2025
9 checks passed
@chenjiahan chenjiahan deleted the assets_retry_0105 branch January 5, 2025 09:53
@chenjiahan chenjiahan mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant