Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: should copy publicDir to the environment distDir when multiple environments (#4220)" #4240

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Dec 22, 2024

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8abff8e
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6768069c48515d00085aaedc
😎 Deploy Preview https://deploy-preview-4240--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 9863b72 into main Dec 22, 2024
10 checks passed
@chenjiahan chenjiahan deleted the revert_copy_1222 branch December 22, 2024 12:39
@chenjiahan chenjiahan mentioned this pull request Dec 22, 2024
@Timeless0911
Copy link
Contributor

This feature is reasonable, but we need to handle the situation where the distPath is the same or the distPath directories have a parent-child relationship.

@chenjiahan
Copy link
Member Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: file already exists when copy public dir to dist [Bug]: Copy public dir to dist failed
2 participants