Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should terminate http server correctly #3261

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 21, 2024

Summary

Terminate http server and await for the callback.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 941839a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66c5f77e512af500085bb138
😎 Deploy Preview https://deploy-preview-3261--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: terminate http server fix: should terminate http server correctly Aug 21, 2024
@chenjiahan chenjiahan merged commit 06c2aaf into main Aug 21, 2024
11 checks passed
@chenjiahan chenjiahan deleted the http_server_close_0821 branch August 21, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant