chore: resolve OutputFileSystem type TODO (#4304)

web-infra-dev · Dec 31, 2024 · f0a4162 · f0a4162 · github-actions · Dec 31, 2024
1 parent 61bde4b
commit f0a4162
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/packages/core/src/server/devServer.ts b/packages/core/src/server/devServer.ts
@@ -21,10 +21,7 @@ import {
   getTransformedHtml,
   loadBundle,
 } from './environment';
-import {
-  type RsbuildDevMiddlewareOptions,
-  getMiddlewares,
-} from './getDevMiddlewares';
+import { type CompileMiddlewareAPI, getMiddlewares } from './getDevMiddlewares';
 import {
   type StartServerResult,
   getAddressUrls,
@@ -128,8 +125,7 @@ export async function createDevServer<
     https,
   };
 
-  // TODO: remove this type assertion after Rspack fix the type definition
-  let outputFileSystem = fs as Rspack.OutputFileSystem;
+  let outputFileSystem: Rspack.OutputFileSystem = fs;
   let lastStats: Rspack.Stats[];
 
   // should register onDevCompileDone hook before startCompile
@@ -148,9 +144,7 @@ export async function createDevServer<
       })
     : Promise.resolve();
 
-  const startCompile: () => Promise<
-    RsbuildDevMiddlewareOptions['compileMiddlewareAPI']
-  > = async () => {
+  const startCompile: () => Promise<CompileMiddlewareAPI> = async () => {
     const compiler = customCompiler || (await createCompiler());
 
     if (!compiler) {
@@ -172,11 +166,10 @@ export async function createDevServer<
 
     await compilerDevMiddleware.init();
 
-    // TODO: remove this type assertion after Rspack fix the type definition
     outputFileSystem =
       (isMultiCompiler(compiler)
         ? compiler.compilers[0].outputFileSystem
-        : compiler.outputFileSystem) || (fs as Rspack.OutputFileSystem);
+        : compiler.outputFileSystem) || fs;
 
     return {
       middleware: compilerDevMiddleware.middleware,