Fixed IndexError when a translation with overridden and unchanged Chooser inside a ListBlock is published #856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affected all
Chooser
s inside aListBlock
, when only one of them is translated and the other kept unchanged.I added a simple empty check to
handle_list_block
so thatself.handle_block
is not called when there are noblock_segments
, which was causing theIndexError
later. This fixes #855.Added two Tests. One with images in a list where only one is changed and another one for a list with
PageChooserBlock
s. Might be redundant, but I wanted to test that this issue is with all choosers and not just thePageChooserBlock
where we encountered it.