Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested ImageBlocks #850

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Handle nested ImageBlocks #850

merged 1 commit into from
Jan 31, 2025

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Jan 31, 2025

Fixes #849

@zerolab zerolab merged commit 0072bab into main Jan 31, 2025
12 checks passed
@zerolab zerolab deleted the imageblock-redux branch January 31, 2025 15:24
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.08%. Comparing base (b619a32) to head (4a90395).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
wagtail_localize/segments/extract.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   93.11%   93.08%   -0.03%     
==========================================
  Files          47       47              
  Lines        4224     4238      +14     
  Branches      547      549       +2     
==========================================
+ Hits         3933     3945      +12     
- Misses        175      176       +1     
- Partials      116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zerolab added a commit that referenced this pull request Jan 31, 2025
zerolab added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using the new ImageBlock inside a StructBlock
2 participants