Add support for filtering the translation report by status #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Annotate the report query with a flag for the status - Add a status filter in the report page - Add tests for the new functionality
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
========================================
Coverage 93.07% 93.07%
========================================
Files 47 47
Lines 4144 4146 +2
Branches 704 529 -175
========================================
+ Hits 3857 3859 +2
Misses 173 173
Partials 114 114 ☔ View full report in Codecov by Sentry. |
My pleasure! Many thanks for looking over my PRs and all your work on this project! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter for filtering by the status of the translation in the translation report.
Note that the filter will not be consistent with the column for translations with sources that don't have any strings, until #829 is merged. So it will appear to not function correctly for such cases.