-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Asset Conversion Guides #5812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, that UI is really nice!
Should the bottom half of this page (the guide essentially) be its own page that exists under PJS Guides, and the user journey placed in this page instead?
Co-authored-by: bader y <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we should make a list of top asset-related user stories for parachain and wallet developers. So we could also have guides on:
- How to create and manage a foreign asset
- How to pay fees using assets
With Rust/TS examples for both.
The `create_pool` function is used to create an empty liquidity pool along with a new `lp_token` | ||
asset. This asset's ID is announced in the `Event::PoolCreated` event. After creating a pool, | ||
liquidity can be added to it via the `Pallet::add_liquidity` function. | ||
|
||
For example, the snapshot below shows how to create liquidity pool with `ROC` tokens and `EDU` | ||
tokens with the asset ID `149` on Rococo Asset Hub. Creating this extrinsic requires knowledge of | ||
[XCM Multilocations](xcm/fundamentals/multilocation/summary.md). From the perspective of AssetHub, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are now Location
s as of XCM v4. May need a new link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a look at the XCM docs tomorrow and see where they may need changes for v4, cc @DrW3RK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I created this issue to track what was requested here #5830
Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
[ ] User Journeys - ParachainsPR Already big. Will do it through a followup PR.