Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asset Conversion Guides #5812

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Add Asset Conversion Guides #5812

merged 9 commits into from
Apr 25, 2024

Conversation

DrW3RK
Copy link
Member

@DrW3RK DrW3RK commented Apr 24, 2024

  • Polkadot-JS guides demonstrating Asset Conversion Pallet functionalities
  • [ ] User Journeys - Parachains PR Already big. Will do it through a followup PR.

@DrW3RK DrW3RK self-assigned this Apr 24, 2024
@DrW3RK DrW3RK added the A1 - In Progress Not ready for review yet. label Apr 24, 2024
@DrW3RK DrW3RK added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Apr 24, 2024
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, that UI is really nice!

Should the bottom half of this page (the guide essentially) be its own page that exists under PJS Guides, and the user journey placed in this page instead?

docs/learn/learn-asset-conversion-assethub.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should make a list of top asset-related user stories for parachain and wallet developers. So we could also have guides on:

  1. How to create and manage a foreign asset
  2. How to pay fees using assets

With Rust/TS examples for both.

docs/learn/learn-asset-conversion-assethub.md Outdated Show resolved Hide resolved
docs/learn/learn-guides-asset-conversion.md Outdated Show resolved Hide resolved
The `create_pool` function is used to create an empty liquidity pool along with a new `lp_token`
asset. This asset's ID is announced in the `Event::PoolCreated` event. After creating a pool,
liquidity can be added to it via the `Pallet::add_liquidity` function.

For example, the snapshot below shows how to create liquidity pool with `ROC` tokens and `EDU`
tokens with the asset ID `149` on Rococo Asset Hub. Creating this extrinsic requires knowledge of
[XCM Multilocations](xcm/fundamentals/multilocation/summary.md). From the perspective of AssetHub,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are now Locations as of XCM v4. May need a new link?

Copy link
Contributor

@CrackTheCode016 CrackTheCode016 Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a look at the XCM docs tomorrow and see where they may need changes for v4, cc @DrW3RK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I created this issue to track what was requested here #5830

@CrackTheCode016 CrackTheCode016 self-requested a review April 25, 2024 15:26
@DrW3RK DrW3RK merged commit efb5c54 into master Apr 25, 2024
3 checks passed
@DrW3RK DrW3RK deleted the asset-conversion-guides branch April 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants