Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow level-id to be different in codec match #3023

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
11 changes: 11 additions & 0 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -1242,5 +1242,16 @@
"web-platform-tests/wpt#48361"
]
}
],
"codec-match-without-level-id": [
{
"description": "Two codecs are considered the same even if level-id is not",
"type": "correction",
"status": "candidate",
"difftype": "modify",
"id": 51,
"pr": 3023,
"testUpdates": "not-testable"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote SDP is testable.

}
]
}
1 change: 1 addition & 0 deletions base-rec.html
Original file line number Diff line number Diff line change
Expand Up @@ -11174,6 +11174,7 @@ <h4 id="methods-8">
</ol>
</div>
<div id="codecmatch-algorithm"><!-- added as anchor to new algo in revised spec --></div>
<div id="codec-match-without-level-id"><!-- amendment to the codecmatch-algorithm --></div>
<div class="note" role="note" id="issue-container-generatedID-47"><div role="heading" class="note-title marker" id="h-note-47" aria-level="5"><span>Note</span></div><p class="">
If set, the offerer's codec preferences will decide the order
of the codecs in the offer. If the answerer does not have any
Expand Down
10 changes: 8 additions & 2 deletions webrtc.html
henbos marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -11443,6 +11443,7 @@ <h2>
given two {{RTCRtpCodec}} dictionaries
<var>first</var> and <var>second</var> is as follows:
</p>
</div>
<ol class=algorithm>
<li>
<p>
Expand All @@ -11467,21 +11468,26 @@ <h2>
</p>
</li>
<li>
<div id="codec-match-without-level-id">
<p>
If either (but not both) of <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}}
and <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}} are [= map/exist | missing =],
or if they both [=map/exist=] and <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}}
is different from <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}}, return
<code>false</code>.
<code>false</code>. Two FMTP lines are the same as long as they convey the same
information, including omitting parameters with well defined defaults or using
henbos marked this conversation as resolved.
Show resolved Hide resolved
different order. In this step, the user agent MUST NOT consider two FMTP lines
different if "media format" is the same and only the highest complying bitstream
level differs.
</p>
</div>
</li>
<li>
<p>
Return <code>true</code>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one of the inputs is garbage the old algorithm returned false. Doesn't this risk returning true if the line is not parseable?

</p>
</li>
</ol>
</div>
<p class="note">
If set, the offerer's receive codec preferences will decide the order
of the codecs in the offer. If the answerer does not have any
Expand Down
Loading