Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(7) Add invalid date test #33

Merged
merged 8 commits into from
Jul 3, 2024
Merged

(7) Add invalid date test #33

merged 8 commits into from
Jul 3, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Jun 19, 2024 •
edited
Loading

Adds an invalid created test for the base and by extension derived proof.

TODO

  • Use a generator to ensure created still shows up in the proof until the implementation used for test data creation can support proof.created.

@aljones15 aljones15 self-assigned this Jun 19, 2024
@aljones15 aljones15 requested a review from BigBlueHat June 19, 2024 18:37
@aljones15 aljones15 force-pushed the add-invalid-date-test branch from 193b15c to b9de1d6 Compare June 20, 2024 14:45
PatStLouis
PatStLouis reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR also includes #34, it makes it difficult to see what belongs to this PR

@aljones15 aljones15 changed the base branch from main to declutter-setup June 21, 2024 15:32
@aljones15
Copy link
Contributor Author

Looks like this PR also includes #34, it makes it difficult to see what belongs to this PR

I retargeted it to point at PR 34. Sorry about that.

@aljones15 aljones15 requested a review from tminard June 21, 2024 15:57
Base automatically changed from declutter-setup to main June 21, 2024 19:35
TallTed
TallTed previously requested changes Jun 25, 2024
View reviewed changes
tests/suites/verify.js Show resolved Hide resolved
@aljones15 aljones15 force-pushed the add-invalid-date-test branch from 232279f to 1024243 Compare June 28, 2024 21:52
@aljones15 aljones15 changed the base branch from main to invalid-cbor-tag June 28, 2024 21:52
@aljones15 aljones15 changed the title Add invalid date test (7) Add invalid date test Jun 28, 2024
@aljones15 aljones15 marked this pull request as ready for review June 28, 2024 21:53
@aljones15 aljones15 force-pushed the add-invalid-date-test branch from 04de411 to 6213634 Compare June 30, 2024 15:09
@aljones15
Copy link
Contributor Author

@TallTed also need re-review here when ready.

TallTed
TallTed reviewed Jul 1, 2024
View reviewed changes
tests/suites/verify.js Outdated Show resolved Hide resolved
Base automatically changed from invalid-cbor-tag to main July 1, 2024 20:22
@aljones15 aljones15 force-pushed the add-invalid-date-test branch from 6213634 to a283aa8 Compare July 1, 2024 20:23
@aljones15 aljones15 requested a review from TallTed July 1, 2024 20:39
@TallTed TallTed mentioned this pull request Jul 3, 2024
Open
@aljones15 aljones15 force-pushed the add-invalid-date-test branch from 46e7673 to 4dbc92a Compare July 3, 2024 17:55
@aljones15 aljones15 dismissed TallTed’s stale review July 3, 2024 17:58

an issue was made about the spec text and this PR has been dangling for 2 weeks.

@aljones15 aljones15 merged commit 56fa544 into main Jul 3, 2024
2 checks passed
@aljones15 aljones15 deleted the add-invalid-date-test branch July 3, 2024 17:58
@TallTed
Copy link
Member

TallTed commented Jul 3, 2024

this PR has been dangling for 2 weeks

Hardly. It's been actively worked on for 2 weeks. It might be considered to have "dangled" for 1 day (since @PatStLouis's approving review), but I think that the "dangling" time is closer to 2 hours, which was more like 1 hour when the above line was written.

@aljones15
Copy link
Contributor Author

this PR has been dangling for 2 weeks

Hardly. It's been actively worked on for 2 weeks. It might be considered to have "dangled" for 1 day (since @PatStLouis's approving review), but I think that the "dangling" time is closer to 2 hours, which was more like 1 hour when the above line was written.

my apologies @TallTed and no offense meant.

@TallTed
Copy link
Member

TallTed commented Jul 3, 2024

Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatStLouis PatStLouis PatStLouis approved these changes

@Wind4Greg Wind4Greg Wind4Greg approved these changes

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

@tminard tminard Awaiting requested review from tminard

@TallTed TallTed Awaiting requested review from TallTed

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aljones15 @TallTed @Wind4Greg @PatStLouis