Do not warn when minutes of group meetings are missing

Groups manage their minutes individually.
w3c · Apr 25, 2024 · af3081a · af3081a
1 parent bbba2de
commit af3081a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/test/check-group-meetings.mjs b/test/check-group-meetings.mjs
@@ -115,16 +115,11 @@ describe('The group meetings module', function () {
     }]);
   });
 
-  it('reports missing minutes when a meeting is past', async function () {
+  it('does not report missing minutes when a meeting is past', async function () {
     const project = await fetchTestProject();
     const sessionNumber = 11;
     const errors = await validateSession(sessionNumber, project);
-    assert.deepStrictEqual(errors, [{
-      session: sessionNumber,
-      severity: 'warning',
-      type: 'minutes',
-      messages: ['Session needs a link to the minutes']
-    }]);
+    assert.deepStrictEqual(errors, []);
   });
 
   it('reports an error when two sessions are scheduled in the same room at the same time', async function () {

diff --git a/test/data/ref-group-meetings.html b/test/data/ref-group-meetings.html
@@ -83,14 +83,14 @@ <h2>Sessions overview</h2>
           <tr>
             <th>Validation warnings</th>
             <td>1</td>
+            <td>3</td>
             <td>4</td>
-            <td>5</td>
           </tr>
           <tr>
             <th>Feel good sessions</th>
             <td>5</td>
-            <td>2</td>
-            <td>7</td>
+            <td>3</td>
+            <td>8</td>
           </tr>
         </tbody>
         <tfoot>

diff --git a/test/data/ref-tpac2023.html b/test/data/ref-tpac2023.html
@@ -83,14 +83,14 @@ <h2>Sessions overview</h2>
           <tr>
             <th>Validation warnings</th>
             <td>0</td>
-            <td>59</td>
-            <td>59</td>
+            <td>2</td>
+            <td>2</td>
           </tr>
           <tr>
             <th>Feel good sessions</th>
             <td>0</td>
-            <td>0</td>
-            <td>0</td>
+            <td>57</td>
+            <td>57</td>
           </tr>
         </tbody>
         <tfoot>

diff --git a/tools/lib/validate.mjs b/tools/lib/validate.mjs
@@ -517,7 +517,9 @@ ${projectErrors.map(error => '- ' + error).join('\n')}`);
 
   // If breakout session took place more than 2 days ago,
   // time to add a link to the minutes
-  if (hasActualMeeting(meetings) && isMaterialMissing('minutes')) {
+  if (project.metadata.type !== 'groups' &&
+      hasActualMeeting(meetings) &&
+      isMaterialMissing('minutes')) {
     const minutesNeeded = meetings
       .filter(meeting => meeting.room && meeting.day && meeting.slot)
       .find(meeting => {