-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add in RDF dataset definitions from SPARQL query #50
Open
pfps
wants to merge
6
commits into
main
Choose a base branch
from
dataset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
78cff60
add in RDF dataset definitions from SPARQL query
pfps 70e6061
remove definition of active graph as it is SPARQL specific
pfps d1e7f07
fix definition markup
pfps 13842cf
Update spec/index.html
pfps e6b5e69
Clean up "merge" definition to use the fragment "dfn-rdf-graph-merge"…
gkellogg 52c0fae
Fix duplicate definitions of "RDF dataset".
gkellogg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RDF Dataset is actually defined in RDF Concepts, although it has an alias here, so it's sufficient to just use an anchor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dfn markup is copied from examples elsewhere. If they are wrong here then I think there are lots that have to be changed throughout the document set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is more complicated than most as the form is to "define" terms which an also defined in RDF Concepts. The
<dfn data-cite="...">...</dfn>
form is there to be able to use these terms as if they're defined in RDF Semantics while referencing the version in RDF Concepts. Note thatdata-lt
provides an alternative way to reference the same definition, but it can also affect the term which is "exported" from the document. It can be useful to look at the Terms defined by this specification section to see what terms are actually defined here.I did scan the other definitions in the document and they seem correct to me.