Introduce a generic skip action as a replacement to skipad. #350

youennf · 2024-12-16T07:56:09Z

Introduce a media kind to allow marking content as either advertisement, generic...
Fixes #340.

youennf · 2024-12-16T08:00:38Z

Bikeshed now requires Python 3.9; you are on 3.8.10.
If you're seeing this message in your CI run, you are
likely specifying an old OS; try ubuntu-latest.
If you're seeing this on the command line, see the docs
for instructions:
https://speced.github.io/bikeshed/#installing
Command bikeshed update failed with exit code: 1.

@tidoust, do you know what happened there?

Needed to get Python >=3.9 for Bikeshed. Also used this opportunity to bump the version of the checkout action used. Via #350 (comment)

tidoust · 2024-12-16T10:41:48Z

@tidoust, do you know what happened there?

Job was using an old version of Ubuntu that ships with Python 3.8. Now using ubuntu-latest, see #351.

steimelchrome · 2024-12-16T17:58:53Z

index.bs

  sequence&lt;MediaImage> artwork = [];
  sequence&lt;ChapterInformationInit> chapterInfo = [];
 };
+
+enum MediaKind {


Can we add a section describing what these mean? "advertisement" is obvious to me, but the rest are not so obvious

I updated the enum and added some description.
Let's discuss this enum.

Does the implementation make use of these values, e.g., in a default action handler? I'm wondering if an enum is needed and we could let the web app set any value it wants, using DOMString.

Also, a web app might want to skip between chapters, so do we need similar on ChapterInformation?

kind could influence UA UI (whether displaying a skip button, for how long, skip button label customisation to Skip intro for instance...). An arbitrary DOMString might add complexity and would disallow feature detection.

do we need similar on ChapterInformation?

Right, this PR adds kind to ChapterInformation as well.

Makes sense, thanks.

This list may be a bit too specific, for example BBC might want to offer a skip to next news item, skip to next song, or whatever.

index.bs

steimelchrome · 2025-01-08T00:01:11Z

index.bs

+      typically happening at the beginning of a TV series episode and summarizing past episodes.
+    </li>
+    <li>
+      the empty string: the default value of media content, it represents any other value of a part of media content.


Seems like empty string will be used to mean both "actual content" and "unknown content". Should there be an explicit value for actual content?

Changed to other for now.

steimelchrome · 2025-01-08T00:01:38Z

This generally lgtm just added a bikeshed comment on the MediaKind enum

marcoscaceres · 2025-01-14T22:06:37Z

index.bs

+  "opening-credits",
+  "post-credits-scene",
+  "summary",
+  ""


Maybe let's just call this "content" ? or "other".

Changed it to other, note that the default value of the dictionary kind value is also updated.

index.bs

youennf · 2025-01-14T22:20:06Z

Discussed today in media WG meeting.
PR seems good with the following changes:

Rename "" to "other" inMediaKind enumeration
Add a note stating that MediaKind enumeration is experimental and can be extended.

I may also add wording about potential default handlers, (seek to next chapter if skipping a chapter or to the end if there is no chapter).

youennf · 2025-01-14T22:34:16Z

@chrisn, would the note and the renaming of "" to "other" cover your concerns? Or do you have a better idea in how to handle the case of "next song", "next news"...?

steimelchrome · 2025-01-21T19:15:58Z

index.bs

@@ -1116,6 +1165,7 @@ dictionary MediaMetadataInit {
    <li>Its <a for=MediaMetadata>title</a> is the empty string.</li>
    <li>Its <a for=MediaMetadata>artist</a> is the empty string.</li>
    <li>Its <a for=MediaMetadata>album</a> is the empty string.</li>
+    <li>Its <a for=MediaMetadata>kind</a> is the empty string.</li>


Should this say the kind is "other"?

steimelchrome · 2025-01-21T19:17:03Z

index.bs

  [SameObject] readonly attribute FrozenArray&lt;MediaImage> artwork;
 };

 dictionary ChapterInformationInit {
  DOMString title = "";
  double startTime = 0;
+  MediaKind kind = "";


Same question here about whether it should be "other"

chrisn · 2025-01-21T19:27:36Z

@chrisn, would the note and the renaming of "" to "other" cover your concerns?

@steimelchrome asked about "actual content" vs "unknown content" so I'm not sure I see how renaming "" to "other" addresses that. For us, there may not be a need to, and "" could be enough as a general purpose skip. But (and separately to the WG) we'd be interested to see what kind of UI treatment browsers might be planning for these skip actions.

Introduce a media kind to allow marking content as either advertisement, generic and so on.

Co-authored-by: Chris Needham <[email protected]>

Co-authored-by: Marcos Cáceres <[email protected]>

…erimental

youennf requested review from steimelchrome, marcoscaceres and alastor0325 December 16, 2024 07:56

youennf force-pushed the generic-skip branch from 9be83a9 to 095f9c7 Compare December 16, 2024 08:06

tidoust added a commit that referenced this pull request Dec 16, 2024

Bump version of Ubuntu used in job

301cfee

Needed to get Python >=3.9 for Bikeshed. Also used this opportunity to bump the version of the checkout action used. Via #350 (comment)

tidoust mentioned this pull request Dec 16, 2024

Bump version of Ubuntu used in job #351

Merged

tidoust added a commit that referenced this pull request Dec 16, 2024

Bump version of Ubuntu used in job (#351)

115bf9e

Needed to get Python >=3.9 for Bikeshed. Also used this opportunity to bump the version of the checkout action used. Via #350 (comment)

youennf force-pushed the generic-skip branch from 095f9c7 to 22f2e57 Compare December 16, 2024 10:48

steimelchrome reviewed Dec 16, 2024

View reviewed changes

youennf force-pushed the generic-skip branch from dd6eede to 03f6850 Compare December 18, 2024 07:29

chrisn reviewed Dec 18, 2024

View reviewed changes

index.bs Outdated Show resolved Hide resolved

chrisn reviewed Dec 18, 2024

View reviewed changes

index.bs Outdated Show resolved Hide resolved

steimelchrome reviewed Jan 8, 2025

View reviewed changes

marcoscaceres approved these changes Jan 14, 2025

View reviewed changes

marcoscaceres reviewed Jan 14, 2025

View reviewed changes

index.bs Show resolved Hide resolved

marcoscaceres reviewed Jan 14, 2025

View reviewed changes

index.bs Show resolved Hide resolved

steimelchrome reviewed Jan 21, 2025

View reviewed changes

youennf and others added 5 commits January 23, 2025 17:10

Introduce a generic skip action as a replacement to skipad.

7492ecb

Introduce a media kind to allow marking content as either advertisement, generic and so on.

Provide more accurate media kinds

61e4594

Update index.bs

5fb2ce3

Co-authored-by: Chris Needham <[email protected]>

Update index.bs

21fbe0c

Co-authored-by: Chris Needham <[email protected]>

Update index.bs

986cf70

Co-authored-by: Marcos Cáceres <[email protected]>

youennf and others added 3 commits January 23, 2025 17:10

Update index.bs

652be79

Co-authored-by: Marcos Cáceres <[email protected]>

Move to other instead of empty string and add a note that kind is exp…

fdab4e7

…erimental

Reverting to empty string + content

d7e2f94

youennf force-pushed the generic-skip branch from f8b1e3c to d7e2f94 Compare January 23, 2025 16:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce a generic skip action as a replacement to skipad. #350

Introduce a generic skip action as a replacement to skipad. #350

youennf commented Dec 16, 2024 •

edited by pr-preview bot

Loading

youennf commented Dec 16, 2024

tidoust commented Dec 16, 2024

steimelchrome Dec 16, 2024

youennf Dec 17, 2024

chrisn Dec 18, 2024

youennf Dec 18, 2024

chrisn Dec 18, 2024

chrisn Jan 9, 2025

steimelchrome Jan 8, 2025

youennf Jan 20, 2025

steimelchrome commented Jan 8, 2025

marcoscaceres Jan 14, 2025 •

edited

Loading

youennf Jan 20, 2025

youennf commented Jan 14, 2025 •

edited

Loading

youennf commented Jan 14, 2025

steimelchrome Jan 21, 2025

steimelchrome Jan 21, 2025

chrisn commented Jan 21, 2025

Introduce a generic skip action as a replacement to skipad. #350

Are you sure you want to change the base?

Introduce a generic skip action as a replacement to skipad. #350

Conversation

youennf commented Dec 16, 2024 • edited by pr-preview bot Loading

youennf commented Dec 16, 2024

tidoust commented Dec 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steimelchrome commented Jan 8, 2025

marcoscaceres Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youennf commented Jan 14, 2025 • edited Loading

youennf commented Jan 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisn commented Jan 21, 2025

youennf commented Dec 16, 2024 •

edited by pr-preview bot

Loading

marcoscaceres Jan 14, 2025 •

edited

Loading

youennf commented Jan 14, 2025 •

edited

Loading