Replace "viewport" with "Initial Containing Block" #76
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the unlinked "viewport" term with a link to the document's initial containing block, which will be the bounds of the browser window or iframe containing the document. Closes: w3c/largest-contentful-paint#26
npm1
reviewed
Sep 1, 2023
| @@ -250,7 +250,7 @@ Report image Element Timing {#sec-report-image-element} | |||
| <div algorithm="report image element timing"> | |||
| When asked to <dfn>report image element timing</dfn> given a triple (|element|, |imageRequest|, |loadTime|), a DOMHighResTimestamp |renderTime| and a {{Document}} |document|, perform the following steps: | |||
|
|
|||
| 1. Let |intersectionRect| be the value returned by the <a>intersection rect algorithm</a> using |element| as the target and viewport as the root. | |||
| 1. Let |intersectionRect| be the value returned by the <a>intersection rect algorithm</a> using |element| as the target and |document|'s [=initial containing block=] as the root. | |||
There was a problem hiding this comment.
Not sure if these are the same. If this element was on an iframe, was viewport the entire page viewport or the iframe's viewport?
There was a problem hiding this comment.
For an element in an iframe, viewport should be the iframe's bounds, and the element should be clipped to that for LCP calculations.
There was a problem hiding this comment.
Ok, makes sense. I guess you need a similar change in the text one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the unlinked "viewport" term with a link to the document's initial containing block, which will be the bounds of the browser window or iframe containing the document.
Closes: w3c/largest-contentful-paint#26
Preview | Diff