Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame viewport clipping is not properly specified #26

Open
yoavweiss opened this issue Jul 23, 2019 · 1 comment · May be fixed by w3c/element-timing#76
Open

Frame viewport clipping is not properly specified #26

yoavweiss opened this issue Jul 23, 2019 · 1 comment · May be fixed by w3c/element-timing#76
Assignees

Comments

@yoavweiss
Copy link
Contributor

Commented by @foolip on #21. Opening a separate issue to track it separately.

@yoavweiss
Copy link
Contributor Author

Looking into this:

  • potentially add LCP entry properly intersects the element's adjusted concrete dimensions with the input intersectionRect.
  • Element timing defines this input intersection rect as the intersection of the element and the viewport.

In the latter part, it seems like "viewport" can link to https://drafts.csswg.org/css2/#viewport and can indicate that it refers to the viewport of the document within which the element is attached.

clelland added a commit to clelland/element-timing that referenced this issue Aug 31, 2023
This replaces the unlinked "viewport" term with a link to the document's initial
containing block, which will be the bounds of the browser window or iframe
containing the document.

Closes: w3c/largest-contentful-paint#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant