Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SVG be supported? #56

Open
npm1 opened this issue Feb 8, 2021 · 1 comment
Open

Should SVG be supported? #56

npm1 opened this issue Feb 8, 2021 · 1 comment

Comments

@npm1
Copy link
Collaborator

npm1 commented Feb 8, 2021

Currently we only support image elements inside SVG, but SVG can have other things. It would be good to think about whether we need to provide more support for SVG. To provide support we'd need to know at least:

  • How to compute the intrinsic size of the SVG? Not sure if this is well-defined for SVGs, as I don't think we could just use their declared size.
  • What timestamp(s) to expose. Is render time after load still good enough here?
@andydavies
Copy link

andydavies commented Apr 13, 2023

Yes, <svg> elements should be supported

They’re visual elements and may well be the true LCP element e.g. where a chart is rendered via SVG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants