Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an explanation for NO_LCP when content is all canvas/SVG #12309

Open
brendankenny opened this issue Mar 30, 2021 · 0 comments
Open

Give an explanation for NO_LCP when content is all canvas/SVG #12309

brendankenny opened this issue Mar 30, 2021 · 0 comments
Labels

Comments

@brendankenny
Copy link
Member

brendankenny commented Mar 30, 2021

Another person ran into #11326: https://twitter.com/FredKSchott/status/1376606554061893633

But currently the error we give is "Something went wrong with recording the trace over your page load. Please run Lighthouse again. (NO_LCP)". In this case, running Lighthouse again will not produce a better result the second time.

I'm not sure if there's anything we can do for the null perf score as long as we require LCP and LCP is defined the way it is (w3c/element-timing#47, w3c/element-timing#56), but we can at least let the user know what's happening.

Hand waving the heuristics here, but if

  • there's no LCP
  • there is painted content
  • all of that content is SVG or canvas

we should give a custom NO_LCP error to let them know the reason for the null score.

related: #11326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants