Add dependency on CID spec. #877
Open
+603
−1,816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
ChristopherA,
davidlehn,
jandrieu,
peacekeeper,
iherman,
dmitrizagidulin,
TallTed,
decentralgabe,
KDean-Dolphin and
brentzundel
TallTed
suggested changes
Jan 6, 2025
Comment on lines
+1268
to
+1269
| <a data-cite="INFRA#string">strings</a>, each of which conforms to the URL | ||
| syntax which are compatible with Section <a href="#did-syntax"></a>. |
There was a problem hiding this comment.
I don't understand what the compatibility is, in order to rephrase to make the sentence say so. Is it each of the strings or the URL syntax that is compatible with Section <a href="#did-syntax">?
Suggested change
| <a data-cite="INFRA#string">strings</a>, each of which conforms to the URL | |
| syntax which are compatible with Section <a href="#did-syntax"></a>. | |
| <a data-cite="INFRA#string">strings</a>, each of which conforms to the URL | |
| syntax which are compatible with Section <a href="#did-syntax"></a>. |
Comment on lines
+1280
to
+1281
| <a data-cite="INFRA#string">strings</a>, each of which conforms to the URL | ||
| syntax which are compatible with Section <a href="#did-syntax"></a>. |
There was a problem hiding this comment.
Again, I don't understand what the compatibility is, in order to rephrase to make the sentence say so. Is it each of the strings or the URL syntax that is compatible with Section <a href="#did-syntax">?
| might take many parameters. An example of this is a set of five cryptographic | ||
| keys from which any three are required to contribute to a cryptographic | ||
| threshold signature. | ||
| A <a>DID document</a> can express <a>verification methods</a>, as defined |
There was a problem hiding this comment.
Suggested change
| A <a>DID document</a> can express <a>verification methods</a>, as defined | |
| A <a>DID document</a> can express <a>verification methods</a>, as defined in |
| <a href="#data-model">data model</a>); see <a href="#did-controller"></a>. | ||
| <p> | ||
| A <a>DID document</a> can express <a>verification relationships</a>, as defined | ||
| <a data-cite="CID#verification-relationships">Section 2.3: Verification |
There was a problem hiding this comment.
Suggested change
| <a data-cite="CID#verification-relationships">Section 2.3: Verification | |
| in <a data-cite="CID#verification-relationships">Section 2.3: Verification |
| <code>publicKeyMultibase</code> at the same time is prohibited. | ||
| </p> | ||
| <p> | ||
| A <a>DID document</a> can express <a>services</a>, as defined |
There was a problem hiding this comment.
Suggested change
| A <a>DID document</a> can express <a>services</a>, as defined | |
| A <a>DID document</a> can express <a>services</a>, as defined in |
| made; for example, it was anchored on a blockchain. | ||
| </li> | ||
| <li> | ||
| For the resolved <a>DID document</a> metadata, the `updated` timestamp is |
There was a problem hiding this comment.
Suggested change
| For the resolved <a>DID document</a> metadata, the `updated` timestamp is | |
| In the resolved <a>DID document</a> metadata, the `updated` timestamp is |
Comment on lines
+2735
to
+2739
| In systems that are willing to admit metadata other than those constituting | ||
| cryptographic input, similar trust may be achieved -- but always on the | ||
| same basis where a careful judgment is made about whether a | ||
| <a>DID document</a>'s content at the moment of a signing event | ||
| contained the expected content. |
There was a problem hiding this comment.
Suggested change
| In systems that are willing to admit metadata other than those constituting | |
| cryptographic input, similar trust may be achieved -- but always on the | |
| same basis where a careful judgment is made about whether a | |
| <a>DID document</a>'s content at the moment of a signing event | |
| contained the expected content. | |
| Similar trust may be achieved in systems that are willing to accept metadata | |
| beyond that which constitutes cryptographic input -- but this always requires | |
| a careful judgment about whether a <a>DID document</a>'s content included the | |
| expected content at the moment of a signing event. |
Comment on lines
+2760
to
+2761
| Performing recovery proactively on an infrequent but regular basis, can help to | ||
| ensure that control has not been lost. |
There was a problem hiding this comment.
Suggested change
| Performing recovery proactively on an infrequent but regular basis, can help to | |
| ensure that control has not been lost. | |
| Proactively performing recovery, on an infrequent but regular basis, can help to | |
| prevent loss of control. |
Comment on lines
+2777
to
+2779
| Recovery is advised when a <a>controller</a> or services trusted to act on their | ||
| behalf no longer have the exclusive ability to perform DID operations as | ||
| described in <a href="#method-operations"></a>. |
There was a problem hiding this comment.
Suggested change
| Recovery is advised when a <a>controller</a> or services trusted to act on their | |
| behalf no longer have the exclusive ability to perform DID operations as | |
| described in <a href="#method-operations"></a>. | |
| Recovery is advised when a <a>controller</a> or any service trusted to act on | |
| their behalf no longer has the exclusive ability to perform DID operations as | |
| described in <a href="#method-operations"></a>. |
Comment on lines
+3090
to
+3096
| not remedial, and is an embedded default. Readers are urged to read the | ||
| <a data-cite="?CID#privacy-considerations">Privacy Considerations</a> section | ||
| in the [[[CID]]] specification before reading this section is it contains | ||
| more general privacy considerations that also apply to <a>DIDs</a>. The rest | ||
| of this section covers privacy considerations that are specific to | ||
| <a>decentralized identifiers</a> beyond the guidance provided in the | ||
| [[[CID]]] specification. |
There was a problem hiding this comment.
Suggested change
| not remedial, and is an embedded default. Readers are urged to read the | |
| <a data-cite="?CID#privacy-considerations">Privacy Considerations</a> section | |
| in the [[[CID]]] specification before reading this section is it contains | |
| more general privacy considerations that also apply to <a>DIDs</a>. The rest | |
| of this section covers privacy considerations that are specific to | |
| <a>decentralized identifiers</a> beyond the guidance provided in the | |
| [[[CID]]] specification. | |
| not remedial, and is an embedded default. Before reading this section, readers | |
| are urged to read the | |
| <a data-cite="?CID#privacy-considerations">Privacy Considerations</a> section | |
| of the [[[CID]]] specification, as it contains | |
| more general privacy considerations that also apply to <a>DIDs</a>. The rest | |
| of this section covers privacy considerations that are specific to | |
| <a>decentralized identifiers</a> and are in addition to the guidance provided | |
| in the [[[CID]]] specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #854 by normatively referencing the Controlled Identifiers specification.
WARNING: This is a BIG PR -- as was requested by the WG. Please keep discussions and change requests limited to editorial changes and suggestions and raise a separate issue, if needed, to track larger structural change requests.
Preview | Diff