Skip to content

Commit

Permalink
Address comments.
Browse files Browse the repository at this point in the history
- Use ByteString instead USVString for requestMethod.
- typos on forgetting "=" in closing "=]".
  • Loading branch information
yoshisatoyanagisawa committed Jan 24, 2024
1 parent 0c966f7 commit 9c57f5f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/

dictionary RouterCondition {
URLPatternCompatible urlPattern;
USVString requestMethod;
ByteString requestMethod;
RequestMode requestMode;
RequestDestination requestDestination;
RunningStatus runningStatus;
Expand Down Expand Up @@ -3279,13 +3279,13 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If running [=match=] with |pattern| and |request|'s [=request/URL=] returns null, [=continue=].
1. If |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestMethod}}"] [=map/exists=], then:
1. Let |method| be |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestMethod}}"].
1. If |request|'s [=request/method] is not |method|, [=continue=].
1. If |request|'s [=request/method=] is not |method|, [=continue=].
1. If |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestMode}}"] [=map/exists=], then:
1. Let |mode| be |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestMode}}"].
1. If |request|'s [=request/mode] is not |mode|, [=continue=].
1. If |request|'s [=request/mode=] is not |mode|, [=continue=].
1. If |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestDestination}}"] [=map/exists=], then:
1. Let |destination| be |rule|["{{RouterRule/condition}}"]["{{RouterCondition/requestDestination}}"].
1. If |request|'s [=request/destination] is not |destination|, [=continue=].
1. If |request|'s [=request/destination=] is not |destination|, [=continue=].
1. If |rule|["{{RouterRule/condition}}"]["{{RouterCondition/runningStatus}}"] [=map/exists=], then:
1. Let |runningStatus| be |rule|["{{RouterRule/condition}}"]["{{RouterCondition/runningStatus}}"].
1. If |runningStatus| is {{RunningStatus/"running"}}, and |serviceWorker| is not [=running=], [=continue=].
Expand Down

0 comments on commit 9c57f5f

Please sign in to comment.