-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: improve load elimination #4407
feat[venom]: improve load elimination #4407
Conversation
Fix lint Co-authored-by: Harry Kalogirou <harkal@nlogn.eu>
--------- Co-authored-by: HodanPlodky <36966616+HodanPlodky@users.noreply.github.com>
f57aab3
to
0155857
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4407 +/- ##
==========================================
+ Coverage 92.09% 92.12% +0.02%
==========================================
Files 119 119
Lines 16936 16967 +31
Branches 2866 2872 +6
==========================================
+ Hits 15598 15631 +33
+ Misses 919 918 -1
+ Partials 419 418 -1 ☔ View full report in Codecov by Sentry. |
fix[venom]: test fixes
Co-authored-by: HodanPlodky <36966616+HodanPlodky@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general. If in the mood, I would:
- change the
self._lattice
to be a local variable. - split the handling of load/store parts of the instruction look to separate methods for cleaner look
What I did
follow up to #4265 but generalize the lattice to multiple keys
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture