feat[venom]: function inliner #4266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helps readability -- they are variables, not addresses!
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ret | ||
|
|
||
| @property | ||
| def _threshold(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| if inst.opcode == "param": | ||
| inst.opcode = "store" | ||
| inst.operands = [invoke_inst.operands[-i - 1]] | ||
| last_param = inst |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
some passes implicitly depend on basic blocks being in cfg traversal order (or at least, basic blocks to be preceded by their dominators)
| @@ -131,10 +145,12 @@ | |||
|
|
|||
| for _ in range(fn.num_basic_blocks): # essentially `while True` | |||
| self._collapse_chained_blocks(entry) | |||
| self.analyses_cache.force_analysis(CFGAnalysis) | |||
| cfg = self.analyses_cache.force_analysis(CFGAnalysis) | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
|
superseded by #4468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
depends #4039
also depends on #4341, otherwise there is a performance regression (due to the promotion of the callee buffer to alloca'ed locations)
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture