Update lark grammar to handle imported types in array/tuple/map def #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple/map definitions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4213 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 119 119
Lines 16967 16967
Branches 2872 2872
=======================================
Hits 15631 15631
Misses 918 918
Partials 418 418 ☔ View full report in Codecov by Sentry. |
cyberthirst
reviewed
Aug 28, 2024
| // NOTE: Map takes a basic type and maps to another type (can be non-basic, including maps) | ||
| _MAP: "HashMap" | ||
| map_def: _MAP "[" ( NAME | array_def ) "," type "]" | ||
| map_def: _MAP "[" ( NAME | imported_type | array_def ) "," type "]" |
There was a problem hiding this comment.
is this correct as mappings, arrays or structs are not supported as key types?
|
Can we please add a test for the imported types? |
|
@benber86 is this still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Current lark grammar can't parse types imported from modules in array/dynarray/tuples/hashmap definitions.
For instance:
How I did it
Added
imported_typeto the array/dynarray/tuple/map def in grammarHow to verify it
Commit message
Update lark grammar to handle imported types in array/tuples definition
Description for the changelog
Cute Animal Picture