-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: add raw_create()
builtin
#4204
Open
charles-cooper
wants to merge
24
commits into
vyperlang:master
Choose a base branch
from
charles-cooper:raw_create
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+291
−0
Open
Changes from 7 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
af85a5c
feat: implement raw_create
charles-cooper a4f2935
add simple test
charles-cooper dc3e377
add tests for raw_create
cyberthirst 2704208
Merge pull request #43 from cyberthirst/raw_create
charles-cooper 394b637
fix buf bound bug
charles-cooper e7025ae
fix total_len
charles-cooper f6caecc
Merge branch 'master' into raw_create
charles-cooper 2870bd9
add tests for raw_create
cyberthirst 513de70
merge value and revert tests
cyberthirst f77c64a
rename test
cyberthirst 961c406
encode args within raw_create
cyberthirst 26698e6
simplify revert condition
cyberthirst 49ccb9b
add comment
cyberthirst 8a07ccb
Merge pull request #45 from cyberthirst/raw_create
charles-cooper c25430a
fix lint
charles-cooper b6a6079
Merge branch 'master' into raw_create
charles-cooper 6fe48c9
add test
trocher 1982adf
add xfail
trocher 96dc6a9
apply suggestion regarding dummy_bytes
trocher 12c1944
Merge pull request #47 from trocher/chore/raw_create_change_length_test
charles-cooper 080b436
remove xfail
charles-cooper af446b0
fix order of eval bug
charles-cooper eafd506
Merge branch 'master' into raw_create
charles-cooper 1aa4e00
Merge branch 'master' into raw_create
charles-cooper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shouldn't be problematic that
copy_bytes
might pad toceil32
, right?it might copy some dirty data, but if arguments are provided, those should overwrite it
if no args are provided, we still operate with
bytecode_len
which will lead to ignoring the dirty data