fix: in and not in comparisons for dynamic arrays of enums

tests/parser/syntax/test_enum.py

@@ -45,19 +45,6 @@
     STAFF
     ADMIN
 
-@external
-def foo(x: Roles) -> bool:
-    return x in [Roles.USER, Roles.ADMIN]
-    """,
-        TypeMismatch,
-    ),
-    (
-        """
-enum Roles:
-    USER
-    STAFF
-    ADMIN
-
 @external
 def foo(x: Roles) -> Roles:
     return x.USER  # can't dereference on enum instance

tests/parser/types/test_dynamic_array.py

@@ -440,6 +440,24 @@ def check(a: {type}) -> bool:
     assert c.check(false_value) is False
 
 
+def test_enum_member_in_list(get_contract_with_gas_estimation):
+    code = """
+enum Foo:
+    A
+    B
+    C
+
+@external
+def check(a: Foo) -> bool:
+    x: DynArray[Foo, 2] = [Foo.A, Foo.C]
+    return a in x
+    """
+    c = get_contract_with_gas_estimation(code)
+    assert c.check(1) is True
+    assert c.check(4) is True
+    assert c.check(2) is False
+
+
 @pytest.mark.parametrize("type_", ("uint256", "bytes32", "address"))
 def test_member_in_empty_list(get_contract_with_gas_estimation, type_):
     code = f"""
@@ -461,6 +479,29 @@ def check_not_in(s: uint128) -> bool:
         assert c.check_not_in(s) is True
 
 
+def test_enum_member_in_empty_list(get_contract_with_gas_estimation):
+    code = """
+enum Foo:
+    A
+    B
+    C
+
+@external
+def check_in(s: Foo) -> bool:
+    x: DynArray[Foo, 2] = []
+    return s in x
+
+@external
+def check_not_in(s: Foo) -> bool:
+    x: DynArray[Foo, 2] = []
+    return s not in x
+    """
+    c = get_contract_with_gas_estimation(code)
+    for s in (1, 2, 4):
+        assert c.check_in(s) is False
+        assert c.check_not_in(s) is True
+
+
 @pytest.mark.parametrize(
     "type,values,false_values",
     [

vyper/semantics/analysis/utils.py

@@ -246,7 +246,9 @@ def types_from_Compare(self, node):
             # x in y
             left = self.get_possible_types_from_node(node.left)
             right = self.get_possible_types_from_node(node.right)
-            if any(isinstance(t, EnumT) for t in left):
+            if any(isinstance(t, EnumT) for t in left) and not any(
+                isinstance(i, (DArrayT, SArrayT)) for i in right
+            ):
                 types_list = get_common_types(node.left, node.right)
                 _validate_op(node, types_list, "validate_comparator")
                 return [BoolT()]