Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize literal bytestrings #3501

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

per title

depends on data directives introduced in #3496 .

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #3501 (35bc569) into master (4ca1c81) will decrease coverage by 31.60%.
The diff coverage is 55.34%.

❗ Current head 35bc569 differs from pull request most recent head 0bbe34d. Consider uploading reports for the commit 0bbe34d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #3501       +/-   ##
===========================================
- Coverage   89.19%   57.60%   -31.60%     
===========================================
  Files          84       85        +1     
  Lines       10979    11299      +320     
  Branches     2507     2570       +63     
===========================================
- Hits         9793     6509     -3284     
- Misses        774     4161     +3387     
- Partials      412      629      +217     
Files Changed Coverage Δ
vyper/cli/vyper_compile.py 16.21% <0.00%> (-47.98%) ⬇️
vyper/codegen/core.py 54.41% <ø> (-32.81%) ⬇️
vyper/compiler/output.py 34.19% <0.00%> (-57.47%) ⬇️
vyper/utils.py 71.28% <ø> (-12.88%) ⬇️
vyper/codegen/module.py 46.66% <41.80%> (-50.96%) ⬇️
vyper/codegen/jumptable_utils.py 41.86% <41.86%> (ø)
vyper/ir/compile_ir.py 75.62% <74.13%> (-18.14%) ⬇️
.../codegen/function_definitions/external_function.py 68.18% <83.33%> (-31.82%) ⬇️
vyper/codegen/expr.py 50.11% <100.00%> (-37.07%) ⬇️
vyper/codegen/function_definitions/__init__.py 100.00% <100.00%> (ø)
... and 2 more

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

optimize bytestrings in both codesize and gas

store them in code, and CODECOPY to memory when needed instead of
inlining
@charles-cooper charles-cooper force-pushed the feat/optimize_bytestring_size branch from 35bc569 to c5ad1d8 Compare July 25, 2023 02:09
@charles-cooper charles-cooper marked this pull request as ready for review July 25, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants