Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ux]: remove side effects in compare_type for bytestrings #3379

Open
wants to merge 75 commits into
base: master
Choose a base branch
from

fix bytes assign check

7b77c7c
Select commit
Loading
Failed to load commit list.
Open

fix[ux]: remove side effects in compare_type for bytestrings #3379

fix bytes assign check
7b77c7c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 23, 2025 in 1s

92.04% (-0.02%) compared to 305813c

View this Pull Request on Codecov

92.04% (-0.02%) compared to 305813c

Details

Codecov Report

Attention: Patch coverage is 92.77108% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.04%. Comparing base (305813c) to head (7b77c7c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
vyper/semantics/types/base.py 40.00% 2 Missing and 1 partial ⚠️
vyper/builtins/_signatures.py 60.00% 1 Missing and 1 partial ⚠️
vyper/codegen/external_call.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.02%     
==========================================
  Files         120      120              
  Lines       17329    17319      -10     
  Branches     2932     2930       -2     
==========================================
- Hits        15954    15942      -12     
- Misses        957      958       +1     
- Partials      418      419       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov