feat: add extend for dynamic arrays #2976
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
+ Coverage 88.35% 88.37% +0.01%
==========================================
Files 97 97
Lines 10968 11003 +35
Branches 2593 2599 +6
==========================================
+ Hits 9691 9724 +33
- Misses 827 828 +1
- Partials 450 451 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vyper/codegen/core.py
Outdated
| return b1.resolve(b2.resolve(ret)) | ||
|
|
||
|
|
||
| def _copy_dynarray_body(dst, src, loop_count=None): |
There was a problem hiding this comment.
is loop_count a necessary parameter for this function?
There was a problem hiding this comment.
If we do not pass in the loop_count from _dynarray_make_setter, the test_nested_struct_of_lists test in tests/parser/types/test_dynamic_array.py will pass with the --no-optimize flag instead of throwing a compilation error. Should I amend the test?
Cool, I think that would be neater since they are used only in |
vyper/builtin_functions/functions.py
Outdated
| dst_start_idx = get_element_ptr(dst, dst_len, array_bounds_check=False) | ||
|
|
||
| # Cast dst start pointer as darray for `_dynarray_make_setter` by subtracting offset | ||
| dst_i = IRnode.from_list(["sub", dst_start_idx, dst.location.word_scale]) |
There was a problem hiding this comment.
kind of bothers me that we still have to adjust the offset like this for copy_dynarray_body
What I did
Add
extend()for dynamic arrays, partial fix for #2611.The source dynamic array (argument) must be of dynamic array type, up to the size of the destination dynamic array.
How I did it
extend_dyn_arrayhelper tocodegen/core.py.extendas member function of dynamic array type.How to verify it
See tests
Commit message
Description for the changelog
Add
extend()for dynamic arrays.Cute Animal Picture