Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pop with index for dynamic arrays #2948

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Jul 3, 2022

What I did

WIP

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #2948 (f88d978) into master (a6c8e5f) will decrease coverage by 21.37%.
The diff coverage is 61.11%.

@@             Coverage Diff             @@
##           master    #2948       +/-   ##
===========================================
- Coverage   88.30%   66.92%   -21.38%     
===========================================
  Files          97       97               
  Lines       10773    10836       +63     
  Branches     2566     2503       -63     
===========================================
- Hits         9513     7252     -2261     
- Misses        802     2937     +2135     
- Partials      458      647      +189     
Impacted Files Coverage Δ
vyper/codegen/expr.py 62.75% <0.00%> (-21.62%) ⬇️
vyper/codegen/core.py 70.32% <18.18%> (-14.56%) ⬇️
vyper/semantics/validation/annotation.py 80.21% <33.33%> (-9.47%) ⬇️
vyper/builtin_functions/functions.py 61.84% <48.38%> (-29.47%) ⬇️
vyper/semantics/types/function.py 66.42% <66.66%> (-20.70%) ⬇️
vyper/codegen/stmt.py 78.66% <71.42%> (-9.51%) ⬇️
vyper/compiler/phases.py 87.50% <90.00%> (-7.42%) ⬇️
vyper/codegen/arithmetic.py 41.46% <100.00%> (-33.85%) ⬇️
vyper/codegen/ir_node.py 91.00% <100.00%> (-1.31%) ⬇️
vyper/codegen/module.py 89.71% <100.00%> (-4.68%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c8e5f...f88d978. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants