Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): avoid header shake when refresh page #4477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(theme): avoid header shake when refresh page #4477

wants to merge 1 commit into from
+2 −2

Conversation

yuyinws
Copy link
Contributor

@yuyinws yuyinws commented Jan 9, 2025

Description

watchPostEffect is trigger after the page rendered, which will let header shake when refresh page. So I use watchEffect replace it.

Before (watchPostEffect) After (watchEffect)
Before After

Linked Issues

resolves #4351

Additional Context

Tip

The author of this PR can publish a preview release by commenting /publish below.

@brc-dd
Copy link
Member

brc-dd commented Jan 9, 2025 •
edited
Loading

This was causing some issues with SSR because class is not rectified in hydration. Earlier classes was just a computed variable. I'll check it later 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The style of the header jitters every time the page is refreshed.
2 participants
@yuyinws @brc-dd