Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add portuguese documentation link #2345

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

nazarepiedady
Copy link
Contributor

In this pull request, I am adding the link to the Portuguese version of the documentation.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit b7647d8
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/64d5e0f5a2e78b00080ea753
😎 Deploy Preview https://deploy-preview-2345--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nazarepiedady nazarepiedady force-pushed the register-portuguese-docs branch from c0f5234 to b7647d8 Compare August 11, 2023 07:19
@nazarepiedady
Copy link
Contributor Author

@posva @Jinjiang @pi0 @patak-dev

Again, sorry to bother you but could you merge this little change?

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you doing the translations only by yourself? It would be better if it's maintained updated by a team and hosted on an org like https://github.com/vuejs-br/br.vuejs.org where other Portuguese translations are hosted.

@nazarepiedady
Copy link
Contributor Author

@posva, Yes I am doing the translation mainly alone but I am accountable so I do not intend to stop to maintain the translation. 😊

Also, I am the person that started translating the vuejs-translations/docs-pt and vitejs/docs-pt and also I am their principal maintainer. ☝️

So do not worry because the project is in good hands 💪 😉.

@nazarepiedady
Copy link
Contributor Author

@posva do you have some time to merge this pull request or could you give it to someone to do it?

Copy link
Member

posva commented Aug 16, 2023

No need to ping like this @nazarepiedady 😉
I will look it when I have time, thanks

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! ❤️
I think you should move the repository to https://github.com/vuejs-translations/ too to give it more visibility among other Portuguese speakers who want to contribute

@posva posva merged commit 8cda62b into vuejs:v2 Aug 17, 2023
@nazarepiedady
Copy link
Contributor Author

@posva the https://github.com/vuejs-translations/ is receiving other translations project beyond the vue documentation?

Copy link
Member

posva commented Aug 25, 2023

maybe not but I think it should, it would make things easier

niceplugin added a commit to niceplugin/Vuejs-Pinia-KO that referenced this pull request Aug 27, 2023
niceplugin added a commit to niceplugin/Vuejs-Pinia-KO that referenced this pull request Aug 27, 2023
* docs: fix fragment links in testing stores page (vuejs#2351)

* docs: add portuguese documentation link (vuejs#2345)

* docs: broken play button on Vue School links (vuejs#2360)

* docs: Add Link to Vue.js Certification (vuejs#2362)

* docs: improved syntax (vuejs#2369)

* docs: mastering pinia
@Jinjiang
Copy link
Member

@nazarepiedady for maintaining the translations of other official vue projects in vuejs-translations org, let me think about that a little bit more and get back to you. It's a good idea in general. We can create another issue or discussion topic for this necessarily.

Beside that, feel free to take a look at this PR and relevant discussion: vuejs/router#1855. That is a new translation workflow which I'm trying recently. I'd like to recommend that to other vue-ecosystem projects. It's more lightweight than the guidelines of vuejs.org translation. Just FYI.

@nazarepiedady
Copy link
Contributor Author

@Jinjiang is it the vuejs-translations receiving the translations for other vuejs projects? I was not informed about this.

Is the process the same as the one defined for the vuejs documentation itself?

@nazarepiedady nazarepiedady deleted the register-portuguese-docs branch July 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants