refactor: define notification duration

vtx22 · Mar 8, 2025 · 32aa0a9 · 32aa0a9
1 parent fec8a9f
commit 32aa0a9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/src/ConfigHandler.cpp b/src/ConfigHandler.cpp
@@ -21,7 +21,7 @@ void ConfigHandler::read_config()
     if (!_ini_file.read(ini))
     {
         std::cerr << "Failed to load config.ini!" << std::endl;
-        ImGui::InsertNotification({ImGuiToastType::Error, 3000, "Failed to read config.ini!"});
+        ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "Failed to read config.ini!"});
     }
 
     std::cout << "Settings:\n";
@@ -51,7 +51,7 @@ void ConfigHandler::write_config()
     if (!_ini_file.write(ini))
     {
         std::cerr << "Failed to write config.ini!" << std::endl;
-        ImGui::InsertNotification({ImGuiToastType::Error, 3000, "Failed to write config.ini!"});
+        ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "Failed to write config.ini!"});
     }
 }
 

diff --git a/src/ConnectionWindow.cpp b/src/ConnectionWindow.cpp
@@ -138,17 +138,17 @@ void ConnectionWindow::update_content()
             {
                 std::cout << "Port opened successfully!\n";
                 _port_open = true;
-                ImGui::InsertNotification({ImGuiToastType::Success, 5000, "COM port opened successfully!"});
+                ImGui::InsertNotification({ImGuiToastType::Success, SPARQ_NOTIFY_DURATION_OK, "COM port opened successfully!"});
             }
             else
             {
                 std::cerr << "Failed to open port! Error: " << rtn << "\n";
-                ImGui::InsertNotification({ImGuiToastType::Error, 5000, "Could not open COM port!"});
+                ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "Could not open COM port!"});
             }
         }
         else
         {
-            ImGui::InsertNotification({ImGuiToastType::Error, 5000, "No COM port selected!"});
+            ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "No COM port selected!"});
         }
     }
     else if (_port_open)
@@ -170,7 +170,7 @@ void ConnectionWindow::update_content()
         std::cout << "Closing COM port ..." << std::endl;
 
         _sp->close();
-        ImGui::InsertNotification({ImGuiToastType::Success, 5000, "COM port closed successfully!"});
+        ImGui::InsertNotification({ImGuiToastType::Success, SPARQ_NOTIFY_DURATION_OK, "COM port closed successfully!"});
         _port_open = false;
     }
     else if (!_port_open)

diff --git a/src/DataHandler.cpp b/src/DataHandler.cpp
@@ -360,7 +360,7 @@ void DataHandler::export_data_csv()
     if (_datasets.size() == 0)
     {
         std::cerr << "No data to export!\n";
-        ImGui::InsertNotification({ImGuiToastType::Error, 5000, "No data to export!"});
+        ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "No data to export!"});
         return;
     }
 
@@ -369,7 +369,7 @@ void DataHandler::export_data_csv()
     if (!file.is_open())
     {
         std::cerr << "Failed to create csv file!\n";
-        ImGui::InsertNotification({ImGuiToastType::Error, 5000, "Failed to create export.csv!"});
+        ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "Failed to create export.csv!"});
         return;
     }
 
@@ -410,7 +410,7 @@ void DataHandler::export_data_csv()
     file.close();
 
     std::cout << "Export successful!\n";
-    ImGui::InsertNotification({ImGuiToastType::Success, 5000, "Data exported to export.csv"});
+    ImGui::InsertNotification({ImGuiToastType::Success, SPARQ_NOTIFY_DURATION_OK, "Data exported to export.csv"});
 }
 
 uint8_t DataHandler::xor8_cs(const uint8_t *data, uint32_t length)

diff --git a/src/sparq.cpp b/src/sparq.cpp
@@ -70,7 +70,7 @@ int SPARQ::window_init()
     else
     {
         std::cerr << "Failed to load " << SPARQ_ICON_FILE << "!\n";
-        ImGui::InsertNotification({ImGuiToastType::Error, 3000, "Failed to load icon.png!"});
+        ImGui::InsertNotification({ImGuiToastType::Error, SPARQ_NOTIFY_DURATION_ERR, "Failed to load icon.png!"});
     }
 
     window.setFramerateLimit(SPARQ_MAX_FPS);

diff --git a/src/sparq_config.h b/src/sparq_config.h
@@ -8,5 +8,7 @@
 #define SPARQ_ICON_FILE "./assets/icon.png"
 
 #define SPARQ_RECEIVE_LOOP_DELAY 1ms
+#define SPARQ_NOTIFY_DURATION_OK 3000
+#define SPARQ_NOTIFY_DURATION_ERR 5000
 
 constexpr bool SPARQ_PLATFORM_LITTLE_ENDIAN = true;