Add comments

volcengine · Feb 25, 2025 · b68b27e · b68b27e
1 parent a698038
commit b68b27e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/verl/workers/fsdp_workers.py b/verl/workers/fsdp_workers.py
@@ -486,6 +486,7 @@ def generate_sequences(self, prompts: DataProto):
 
     @register(dispatch_mode=Dispatch.DP_COMPUTE_PROTO)
     def chat(self, prompts: DataProto):
+        # copy from generate_sequences func
         prompts = prompts.to('cuda')
 
         assert self._is_rollout
@@ -513,6 +514,7 @@ def chat(self, prompts: DataProto):
             log_gpu_memory_usage('After entering rollout sharding manager', logger=logger)
 
             prompts = self.rollout_sharding_manager.preprocess_data(prompts)
+            # change this func but get same return
             output = self.rollout.chat(prompts=prompts)
 
             log_gpu_memory_usage('After rollout generation', logger=logger)

diff --git a/verl/workers/rollout/vllm_rollout/vllm_rollout.py b/verl/workers/rollout/vllm_rollout/vllm_rollout.py
@@ -266,5 +266,6 @@ def chat(self, prompts: DataProto, **kwargs) -> DataProto:
         }
         prompt_data.meta_info.update(meta_info)
         prompt_data.to('cuda')
+
         # use generate_sequences to get return
         return self.generate_sequences(prompt_data, **kwargs)